Bug 219737 - Update math/glm to version 0.9.8.4
Summary: Update math/glm to version 0.9.8.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-02 20:11 UTC by Pedro F. Giffuni
Modified: 2017-06-04 17:48 UTC (History)
1 user (show)

See Also:

Attachments
Diff to update math/glm (8.63 KB, patch)
2017-06-02 20:11 UTC, Pedro F. Giffuni 		no flags Details | Diff
libdata path fix (434 bytes, patch)
2017-06-04 17:41 UTC, Pedro F. Giffuni 		no flags Details | Diff
libdata path fix (435 bytes, patch)
2017-06-04 17:42 UTC, Pedro F. Giffuni 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2017-06-02 20:11:44 UTC 
Created attachment 183161 [details]
Diff to update math/glm

Many fixes:

https://github.com/g-truc/glm/releases

Most notable:

Added Clang 4.0 detection
Fixed GCC 4.8 with C++11 compilation option

I removed the old patch since it doesn't apply to the existing code and we don't support FreeBSD 8.x or 9.x anymore.
RDo not disable the test option if under MAINTAINER_MODE.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2017-06-04 06:14:34 UTC 
Is there a reason you install pkgconfig/glm.pc to lib/ instead of libdata/ ?
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2017-06-04 06:14:58 UTC 
Ups, too early
Comment 3 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-06-04 15:45:58 UTC 
(In reply to Kurt Jaeger from comment #1)

Not really, I didn't touch that from the previous port. (I'll look at it).
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2017-06-04 15:55:25 UTC 
No need, I already have a fix and will add it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-06-04 15:58:04 UTC 
A commit references this bug:

Author: pi
Date: Sun Jun  4 15:57:54 UTC 2017
New revision: 442566
URL: https://svnweb.freebsd.org/changeset/ports/442566

Log:
  math/glm: update 0.9.7.3 -> 0.9.8.4

  - Many changes
  - move lib/pkgconfig/glm.pc to libdata/pkgconfig/

  PR:		219737
  Submitted by:	pfg
  Relnotes:	https://github.com/g-truc/glm/releases

Changes:
  head/math/glm/Makefile
  head/math/glm/distinfo
  head/math/glm/files/patch-CMakeLists.txt
  head/math/glm/files/patch-glm_detail_setup.hpp
  head/math/glm/pkg-plist
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2017-06-04 15:58:47 UTC 
Committed, thanks!
Comment 7 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-06-04 16:32:28 UTC 
FWIW, ...

(In reply to Kurt Jaeger from comment #4)

The path should have been set unconditionally so sometihng like this would be better:

CMAKE_ARGS=	-DCMAKE_INSTALL_PKG_CONFIG_DIR:PATH="${PREFIX}/libdata/pkgconfig"

.ifndef MAINTAINER_MODE
CMAKE_ARGS+=	-DGLM_TEST_ENABLE:BOOL=OFF
.endif

(excuse the formatting)
Comment 8 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-06-04 17:19:07 UTC 
(In reply to Pedro F. Giffuni from comment #7)

I suspect the change in subversion broke the pkg-plist in MAINTAINER_MODE.
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-06-04 17:21:11 UTC 
A commit references this bug:

Author: pi
Date: Sun Jun  4 17:21:01 UTC 2017
New revision: 442571
URL: https://svnweb.freebsd.org/changeset/ports/442571

Log:
  math/glm: remove flag from MAINTAINER_MODE case

  PR:		219737
  Submitted by:	pfg

Changes:
  head/math/glm/Makefile
Comment 10 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-06-04 17:41:33 UTC 
Created attachment 183214 [details]
libdata path fix

I meant this.
Comment 11 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-06-04 17:42:48 UTC 
Created attachment 183215 [details]
libdata path fix

(oops)
Comment 12 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-06-04 17:48:28 UTC 
Comment on attachment 183215 [details]
libdata path fix

Nevermind .. the patch in files/ does the same.