Bug 220081 - science/metaf2xml: Update to 2.2
Summary: science/metaf2xml: Update to 2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Richard Gallamore
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-06-17 14:32 UTC by metaf2xml
Modified: 2017-06-29 19:37 UTC (History)
2 users (show)

See Also:


Attachments
patch to update science/metaf2xml to 2.2 (996 bytes, text/plain)
2017-06-17 14:32 UTC, metaf2xml
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description metaf2xml 2017-06-17 14:32:01 UTC
Created attachment 183572 [details]
patch to update science/metaf2xml to 2.2

Attached a proposed patch to upgrade the port for science/metaf2xml to 2.2. The patch has the following changes:

- Makefile: change PORTVERSION to 2.2
- Makefile: change LICENSE from dual GPLv2 GPLv3 to GPLv2+

Please apply the patch. Thanks!
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-06-25 16:19:34 UTC
A commit references this bug:

Author: ultima
Date: Sun Jun 25 16:19:05 UTC 2017
New revision: 444302
URL: https://svnweb.freebsd.org/changeset/ports/444302

Log:
  * Updated to 2.2

  Changelog:	http://metaf2xml.sourceforge.net/RelInfo-2.2.txt

  PR:		220081
  Submitted by:	<metaf2xml@users.sourceforge.net>
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11313

Changes:
  head/science/metaf2xml/Makefile
  head/science/metaf2xml/distinfo
  head/science/metaf2xml/files/
  head/science/metaf2xml/files/patch-install.pl
Comment 2 Richard Gallamore freebsd_committer freebsd_triage 2017-06-25 16:26:36 UTC
Committed, thanks!
Comment 3 metaf2xml 2017-06-29 16:04:05 UTC
Please fix, or even better revert, the changes in rP444302 which were not submitted by me with this PR. They create relative symlinks which point to non-existing files.

Please reconsider if you find this feature so useful that it is worth the added complexity of the port. It has caused additional efforts already.

In addition, the (correct) use of relative symlinks here would hard-code that:
- WWWDIR must be a subdirectory of PREFIX,
- PREFIX/bin must be 3 levels up from WWWDIR/cgi-bin, and
- DATADIR must be 3 levels up from WWWDIR/htdocs.
If any of this changes in the future, or is not fulfilled for all port environments, the installation will again create broken symlinks.
I think instead of warning that absolute symlinks are "bad", the Q/A tool should rather check that symlinks are not broken.

Maybe you can also check if USES=shebangfix and SHEBANG_FILES=... can be dropped from the port Makefile, as (since 2.2) install.pl already replaces the Perl paths with the value of $PERL.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-06-29 19:22:31 UTC
A commit references this bug:

Author: ultima
Date: Thu Jun 29 19:22:06 UTC 2017
New revision: 444683
URL: https://svnweb.freebsd.org/changeset/ports/444683

Log:
  * Fix broken symlinks

  PR:		220081
  Reported by:	<metaf2xml@users.sourceforge.net>
  Reviewed by:	lifanov (mentor)
  Approved by:	lifanov (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11409

Changes:
  head/science/metaf2xml/Makefile
Comment 5 Richard Gallamore freebsd_committer freebsd_triage 2017-06-29 19:37:46 UTC
(In reply to metaf2xml from comment #3)
Sorry for the breakage,r444683 this should fix the issue.

Absolute paths can point to a wrong location, like when a remote file system has been mounted with NFS under a non-root mount point. Relative paths are less fragile, and often much shorter[1]. This is the correct way to handle symlinks to comply with FreeBSD porting standards. I understand why you think it is the incorrect method as I felt the same in the past.


[1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#staging