Created attachment 183573 [details] opengrok-1.0.diff QA: poudriere testport passed on 11.0R-amd64
Thanks for taking over this port. Can you please move the LICENSE.txt to LICENSE_FILE=. and provide the portlint.
Created attachment 183755 [details] opengrok-1.0.diff move LICENSE.txt to LICENSE_FILES= portlint -AC WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. 0 fatal errors and 1 warning found.
(In reply to Richard Gallamore from comment #1) Thanks, fixed!
Just noticed one more thing that I should have mentioned before. The MASTER_SITES has changed to github. Instead of setting MASTER_SITES for github, please add USE_GITHUB, and GH_ACCOUNT and the other GITHUB_* entries required, usually just those two.
(In reply to Richard Gallamore from comment #4) Hi Richard, this is a java port and the distfile is compiled binary java libs, if I change to use USE_GITHUB etc, the download file will be the java source. It is not nessisory to compile this port from source as the original 0.12.1.5 also did not do so.
Okay, didn't know it was pre-compiled.
All of the .if ${PORT_OPTIONS:MOPT} WEBAPP_HOME?= ${LOCALBASE}/apache-tomcat-8.5 .endif can be changed to OPT_VAR= WEBAPP_HOME?= ${LOCALBASE}/apache-tomcat-x.x or similar. This will clean up the port a little bit, can you please adjust these entries?
I tested these changes I just commented on and was failing to build, so I am going to go ahead and commit as is. If you can in the future, changing the port to compiling from source instead of using precompiled source is much preferred. Thanks again for taking over all these ports!
(In reply to Richard Gallamore from comment #8) Build java ports from source is a good idea，if I have enough time，I will try.Thanks for committing my PR!
Created attachment 183853 [details] opengrok.diff This is the small change requested previously and passes QA. The set default (?) was the cause for the previous failures. Does this look good?
Comment on attachment 183853 [details] opengrok.diff Look good to me，please go forward，thanks！
A commit references this bug: Author: ultima Date: Wed Jun 28 01:43:44 UTC 2017 New revision: 444533 URL: https://svnweb.freebsd.org/changeset/ports/444533 Log: * Updated to 1.0 * New maintainer Jov <amutu@amutu.com> * New options, TOMCAT 8 and 85, 8 is the new default Changelog: https://github.com/OpenGrok/OpenGrok/releases/tag/1.0 PR: 220082 Submitted by: Jov <amutu@amutu.com> (maintainer) Reviewed by: lifanov (mentor), matthew (mentor) Approved by: lifanov (mentor), matthew (mentor) Differential Revision: https://reviews.freebsd.org/D11355 Changes: head/devel/opengrok/Makefile head/devel/opengrok/distinfo head/devel/opengrok/pkg-plist
Committed, thanks!