Created attachment 183649 [details] mbdyn-1.7.2.diff QA: portlint -AC WARN: Makefile: [47]: possible direct use of command "which" found. use ${WHICH} instead. WARN: Makefile: [65]: possible direct use of command "which" found. use ${WHICH} instead. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. 0 fatal errors and 3 warnings found. poudriere testport on 11.0R-amd64 :default option, chaco+metis+gotoblas, chaco+metis+atlas NOTE: 1.add gcc depend to fix this problem(also exists on 1.7.1). 2.add libtool:build option to fix build error. 3.remove un-used patch because there changes already pushed to upstream.
Hello Jov, thanks for taking the time to fix this port and maintain it. This patch adds the lib gcc5. Instead of adding this as a lib depend, can you please use USE_GCC= 5.
(In reply to Richard Gallamore from comment #1) I try to use USE_GCC=5+ but the QA error still there，only using the lib_depends can make the warning disappeared.As the original 1.7.1 has this error too, I think this is a false negative,so I just remove the gcc lib depends leave this as is. note the QA test only run when set DEVELOPER=yes to /etc/make.conf: Running Q/A tests (stage-qa) Error: /usr/local/bin/ann_in is linked to /usr/local/lib/gcc5/libgfortran.so.3 from lang/gcc but it is not declared as a dependency Error: /usr/local/bin/ann_in is linked to /usr/local/lib/gcc5/libquadmath.so.0 from lang/gcc but it is not declared as a dependency Error: /usr/local/bin/c81merge is linked to /usr/local/lib/gcc5/libstdc++.so.6 from lang/gcc but it is not declared as a dependency Error: /usr/local/bin/c81merge is linked to /usr/local/lib/gcc5/libgcc_s.so.1 from lang/gcc but it is not declared as a dependency
(In reply to Jov from comment #2) Just compiled the port without the gcc5 LIB_DEPENDS entry or USE_GCC= 5+ completed successfully without the Errors. I also compiled with the USE_GCC= 5+ entry without the error. https://poudriere.ultimasbox.com/data/103amd64-test/2017-06-27_06h54m08s/logs/mbdyn-1.7.2.log Are you sure this is required? I'm not finding any documentation declaring these are a requirement. Is it really a necessary entry or did I possibly miss it in a document? The USE= compiler:c++11-lib and other USE entries should take care of the compiler requirements.
(In reply to Richard Gallamore from comment #3) Yes, the poudriere testport build OK.the QA error only shows when I build from my local host and make.conf with DEVELOPER=yes set. That's why I think it is a false negative.
(In reply to Jov from comment #4) Yeah it is probably just a false positive from a dirty environment, don't worry about the error. Leave gcc out of depends and let the USE/USES deal with those.
Created attachment 184055 [details] mbdyn-1.7.2.diff no lib_depends and USE for gcc5.
(In reply to Richard Gallamore from comment #5) I removed the gcc5 lib depends and USE_GCC=5+ as you said. So please go forward.
GINAC_DESC= Enable GiNaC-support (not implemented yet) If GINAC is not implemented, should we just remove this options?
Any idea what the point of the option is?
Created attachment 184064 [details] mbdyn-1.7.2.diff remove GiNaC-support,which is not implement on FreeBSD
(In reply to Richard Gallamore from comment #9) From the commit history: https://github.com/freebsd/freebsd-ports/commit/aba91219338387fa74e3cdfe2d1fdf89f6d0dfec this option mark broken when upgrade from 1.4.x to 1.7.x.
I had some contact with the authors of this package and they noted the MPI support is dead (it was always very slow). Most of the patches are therefore not needed. I am not sure about GiNac, I recall vaguely bu I am not sure someone built with it a newer version on macOS.
Comment on attachment 184064 [details] mbdyn-1.7.2.diff Port is unmaintained, implicit approval
Created attachment 184065 [details] mbdyn.diff * Added previous patches for removal of ginac and mpi * Moved BROKEN_* above *_DEPENDS, BROKEN_* comes before *_DEPENDS * Sorted options section and removed some unneeded bits feedback? The mpi option can be omitted and decided on later.
A commit references this bug: Author: ultima Date: Wed Jul 5 15:50:44 UTC 2017 New revision: 445084 URL: https://svnweb.freebsd.org/changeset/ports/445084 Log: * Updated to 1.7.2 * New maintainer Jov <amutu@amutu.com> * Sorted options Changelog: https://www.mbdyn.org/userfiles/downloads/CHANGELOG-1.7.txt PR: 220157 Submitted by: Jov <amutu@amutu.com> (maintainer), pfg Reviewed by: matthew (mentor), matt Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D11481 Changes: head/science/mbdyn/Makefile head/science/mbdyn/distinfo head/science/mbdyn/files/
Comment on attachment 184064 [details] mbdyn-1.7.2.diff Committed, Thanks Jov, and Pedro!