Bug 220165 - usr.sbin/makefs/makefs_ffs_tests: o_flag_version_1 and o_flag_version_2 tests fail if /etc/fstab is nonexistent
Summary: usr.sbin/makefs/makefs_ffs_tests: o_flag_version_1 and o_flag_version_2 tests...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: Alan Somers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-20 18:29 UTC by Glen Barber
Modified: 2017-08-25 01:50 UTC (History)
2 users (show)

See Also:
asomers: mfc-stable11?
asomers: mfc-stable10?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Glen Barber freebsd_committer 2017-06-20 18:29:58 UTC
Sample output of o_flag_version_1 within a chroot(8) with no /etc/fstab present:

===> usr.sbin/makefs/makefs_ffs_tests:o_flag_version_1
Result:     failed: atf-check failed; see the output of the test for details
Start time: 2017-06-20T16:14:52.040579Z
End time:   2017-06-20T16:14:52.367176Z
Duration:   0.327s

Metadata:
    allowed_architectures is empty
    allowed_platforms is empty
    description is empty
    has_cleanup = true
    is_exclusive = false
    required_configs is empty
    required_disk_space = 0
    required_files is empty
    required_memory = 0
    required_programs is empty
    required_user is empty
    timeout = 300

Standard output:
Executing command [ mkdir -m 0777 -p /tmp/kyua.6rKiWR/781/work/mnt ]
Executing command [ mkdir -m 0777 -p /tmp/kyua.6rKiWR/781/work/inputs ]
Executing command [ mkdir -m 0755 -p a/b/1 ]
Executing command [ ln -s a/b c ]
Executing command [ touch d ]
Executing command [ ln d e ]
Executing command [ touch .f ]
Executing command [ mkdir .g ]
Executing command [ dd if=/dev/zero of=i count=1000 bs=1 ]
Executing command [ touch klmn ]
Executing command [ touch opqr ]
Executing command [ touch stuv ]
Executing command [ install -m 0755 /dev/null wxyz ]
Executing command [ touch 0b00000001 ]
Executing command [ touch 0b00000010 ]
Executing command [ touch 0b00000011 ]
Executing command [ touch 0b00000100 ]
Executing command [ touch 0b00000101 ]
Executing command [ touch 0b00000110 ]
Executing command [ touch 0b00000111 ]
Executing command [ touch 0b00001000 ]
Executing command [ touch 0b00001001 ]
Executing command [ touch 0b00001010 ]
Executing command [ touch 0b00001011 ]
Executing command [ touch 0b00001100 ]
Executing command [ touch 0b00001101 ]
Executing command [ touch 0b00001110 ]
Executing command [ dd if=/dev/zero of=1.file bs=1 count=1 oseek=1 conv=sparse ]
Executing command [ dd if=/dev/zero of=512.file bs=1 count=1 oseek=512 conv=sparse ]
Executing command [ dd if=/dev/zero of=2048.file bs=1 count=1 oseek=2048 conv=sparse ]
Executing command [ dd if=/dev/zero of=10240.file bs=1 count=1 oseek=10240 conv=sparse ]
Executing command [ dd if=/dev/zero of=524288.file bs=1 count=1 oseek=524288 conv=sparse ]
Executing command [ makefs -t ffs -M 1m -o version=1 /tmp/kyua.6rKiWR/781/work/test.img /tmp/kyua.6rKiWR/781/work/inputs ]
Executing command [ mdconfig -a -f /tmp/kyua.6rKiWR/781/work/test.img ]
Executing command [ mount /dev/md0 /tmp/kyua.6rKiWR/781/work/mnt ]
Executing command [ dumpfs /tmp/kyua.6rKiWR/781/work/mnt ]

Standard error:
Fail: stderr not empty
--- /dev/null   2017-06-20 16:14:42.000000000 +0000
+++ /tmp/kyua.6rKiWR/781/work/check.7DQl1P/stderr       2017-06-20 16:14:52.355087000 +0000
@@ -0,0 +1 @@
+fstab: /etc/fstab:0: No such file or directory
Files left in work directory after failure: inputs, md.output, mnt, test.img
===> Failed tests
usr.sbin/makefs/makefs_ffs_tests:o_flag_version_1  ->  failed: atf-check failed; see the output of the test for details  [0.327s]
===> Summary
Results read from /root/.kyua/store/results.usr_tests.20170620-155827-682012.db
Test cases: 1 total, 0 skipped, 0 expected failures, 0 broken, 1 failed
Start time: 2017-06-20T16:14:52.040579Z
End time:   2017-06-20T16:14:52.367176Z
Total time: 0.327s
Comment 1 commit-hook freebsd_committer 2017-06-20 19:01:47 UTC
A commit references this bug:

Author: asomers
Date: Tue Jun 20 19:00:55 UTC 2017
New revision: 320163
URL: https://svnweb.freebsd.org/changeset/base/320163

Log:
  Fix usr.sbin/makefs/makefs_ffs_tests when /etc/fstab does not exist

  dumpfs prints a harmless warning message (via ufs_disk_fillout(3) and
  getfsfile(3)), when /etc/fstab does not exist.  We can ignore it.

  PR:		220165
  Reported by:	gjb
  MFC after:	3 weeks
  Sponsored by:	Spectra Logic Corp

Changes:
  head/usr.sbin/makefs/tests/makefs_ffs_tests.sh
Comment 2 commit-hook freebsd_committer 2017-07-05 16:00:42 UTC
A commit references this bug:

Author: asomers
Date: Wed Jul  5 15:59:52 UTC 2017
New revision: 320681
URL: https://svnweb.freebsd.org/changeset/base/320681

Log:
  MFC r320163:

  Fix usr.sbin/makefs/makefs_ffs_tests when /etc/fstab does not exist

  dumpfs prints a harmless warning message (via ufs_disk_fillout(3) and
  getfsfile(3)), when /etc/fstab does not exist.  We can ignore it.

  PR:		220165
  Reported by:	gjb
  Sponsored by:	Spectra Logic Corp

Changes:
_U  stable/11/
  stable/11/usr.sbin/makefs/tests/makefs_ffs_tests.sh
Comment 3 commit-hook freebsd_committer 2017-07-31 21:52:17 UTC
A commit references this bug:

Author: asomers
Date: Mon Jul 31 21:52:08 UTC 2017
New revision: 321820
URL: https://svnweb.freebsd.org/changeset/base/321820

Log:
  MFC r320163:

  Fix usr.sbin/makefs/makefs_ffs_tests when /etc/fstab does not exist

  dumpfs prints a harmless warning message (via ufs_disk_fillout(3) and
  getfsfile(3)), when /etc/fstab does not exist.  We can ignore it.

  PR:		220165
  Reported by:	gjb
  Sponsored by:	Spectra Logic Corp

Changes:
_U  stable/10/
  stable/10/usr.sbin/makefs/tests/makefs_ffs_tests.sh