Bug 220396 - www/qt4-webkit: unbreak build on aarch64
Summary: www/qt4-webkit: unbreak build on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL: http://thunderx1.nyi.freebsd.org/data...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-06-30 21:33 UTC by Poul-Henning Kamp
Modified: 2017-07-07 09:12 UTC (History)
3 users (show)

See Also:

Attachments
Changes to existing patch (1.05 KB, patch)
2017-06-30 21:33 UTC, Poul-Henning Kamp 		no flags Details | Diff
Extra patch needed for arm64/RPi3 (592 bytes, patch)
2017-06-30 21:34 UTC, Poul-Henning Kamp 		no flags Details | Diff
use aarch64 (3.12 KB, patch)
2017-07-01 07:57 UTC, Tobias C. Berner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Poul-Henning Kamp freebsd_committer freebsd_triage 2017-06-30 21:33:20 UTC 
Created attachment 183964 [details]
Changes to existing patch

I needed these patches to compile on a RPi3
Comment 1 Poul-Henning Kamp freebsd_committer freebsd_triage 2017-06-30 21:34:03 UTC 
Created attachment 183965 [details]
Extra patch needed for arm64/RPi3
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2017-07-01 07:57:27 UTC 
Created attachment 183979 [details]
use aarch64

Hi

Does the extrapatch break compilation for non-RPI3 aarch64?
If not I would suggest something like attached patch.

mfg Tobias
Comment 3 Poul-Henning Kamp freebsd_committer freebsd_triage 2017-07-01 08:09:27 UTC 
To be honest, I have not tried that.  Eyeballing the code, I can't see how it could break other archs.
Comment 4 groot 2017-07-07 09:03:37 UTC 
tcberner@'s patch changes nothing for non-aarch64 platforms, so I'm inclined to prefer that one. But as phk@ says, adding those extra 64 bytes into the `storage` buffer is (eyeball) not going to affect other arches.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-07-07 09:10:49 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Jul  7 09:10:13 UTC 2017
New revision: 445225
URL: https://svnweb.freebsd.org/changeset/ports/445225

Log:
  www/qt4-webkit: unbreak build on aarch64

  PR:		220396
  Submitted by:	phk (original version)

Changes:
  head/www/qt4-webkit/files/patch-src_3rdparty_webkit_Source_JavaScriptCore_runtime_JSGlobalData.cpp
  head/www/qt4-webkit/files/patch-src__3rdparty__webkit__Source__JavaScriptCore__runtime__JSValueInlineMethods.h
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2017-07-07 09:12:20 UTC 
Thanks.