Created attachment 184010 [details] calculix-ccx as a shar file Break up the cad/calculix port in the two parts that compose it. The command-line tool for analyzing mechanical structures has it's own requirements in that it uses OpenMP and a Fortran compiler. Having it independent is much more useful and eases the maintainance. And independent PR with the GraphiX part will be submitted shortly.
Created attachment 184011 [details] calculix-cxx port as a diff for easier reading
Given this and other related bugs split up an existing port into separate (new) ports, I'd consider bundling them up into a single changeset/issue/review, as they will need to be committed at once/together/atomically
Minor nit: I'd tweak each new ports COMMENT so that its clear which part of the whole each port provides
Thank you, Pedro! I know realize you were looking for a ports committer to review/approve, which I am happy to help with: Could you use ${DIST_PS} in EXTRACT_ONLY+= ${DIST_HTM} ccx_${PORTVERSION}.ps${EXTRACT_SUFX} ? Why do you have + @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} + @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} twice? I personally would have found a comment on the use of EXTRACT_ONLY helpful; it took me a bit to understand why you had to use that. ;-) Can you combine the two blocks starting with +.if ${PORT_OPTIONS:MEXAMPLES} and +.if empty(PORT_OPTIONS:MEXAMPLES) ? And there should be a tab before METIS in OPTIONS_SINGLE= METIS. I suggest you add a comment on why ALL_TARGET is set empty. In pkg-descr it's "can be built" (instead of "build"), but better even use active form such as "Build, calculate, and post-process Calc..."? (Note the Oxford comma before "and post-process" in either case.) And omit the trailing / in the URL. Approved by: gerald with the changes above (and suggestions at least considered). Thank you!
Created attachment 185374 [details] Updated version OK, I applied you feedback, huge thanks! Most was leftover cruft from the older "merged" port.
You're very welcome, Pedro! One area where I may not have been clear enough. If we look at +.if ${PORT_OPTIONS:MEXAMPLES} +DISTFILES+= ${DIST_EXAMPLES} +EXTRACT_ONLY+= ${DIST_EXAMPLES} +.endif and +.if empty(PORT_OPTIONS:MEXAMPLES) +PLIST_SUB= PORTEXAMPLES="@comment " +.else +PLIST_SUB= PORTEXAMPLES="" +.endif can these two be merged into just one?
(In reply to Gerald Pfeifer from comment #6) Yes.. I am resting that ... and an issue I just noticed with a perl shebang.
Created attachment 185380 [details] Updated version: take 2 Update. Note: the uses a date.pl script which requires some investigation for reproducibility purposes. I should also add a build dependency to perl, however it appears we have never had issues is perl is not found so I will defer that to a future revision.
Committed as part of r447973.