Bug 220642 - devel/pecl-pthreads: Update to 3.1.6
Summary: devel/pecl-pthreads: Update to 3.1.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-11 16:41 UTC by johnpupu
Modified: 2017-07-13 00:02 UTC (History)
2 users (show)

See Also:

Attachments
pecl-pthreads.patch (1.55 KB, text/plain)
2017-07-11 16:41 UTC, johnpupu 		no flags Details
Updated patch for 3.1.6 per Po-Chuan's comments (1.47 KB, patch)
2017-07-11 18:47 UTC, amistry 		johnpupu: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description johnpupu 2017-07-11 16:41:46 UTC 

    


    


      



        
          Comment 1
        

        
          johnpupu

        

        
        

        
          2017-07-11 16:41:49 UTC
        

      






Created attachment 184266 [details]
pecl-pthreads.patch

    


    


      



        
          Comment 2
        

        
          amistry

        

        
        

        
          2017-07-11 18:07:38 UTC
        

      






pthreads is not yet compatible with PHP 7.1.  It should be once Joe releases 3.1.7 as the git head is compatible.  We may want to use IGNORE_WITH_PHP=56 71 for now until the next update from upstream.

    


    


      



        
          Comment 3
        

        
          Po-Chuan Hsieh

        

        
            freebsd_committer
            freebsd_triage
        

        
          2017-07-11 18:16:34 UTC
        

      






You need to update your patch. There are some issues:
- You've reverted USES=php:pecl update by mat@.
- Is there any reason to use tarball from GitHub (USE_GITHUB=yes, GH_ACCOUNT=krakjoe, GH_TAGNAME=2645c78)?
- The trailing "-" of CONFLICTS_INSTALL=pecl-pthreads- is incorrect. And it conflicts with itself?

    


    


      



        
          Comment 4
        

        
          amistry

        

        
        

        
          2017-07-11 18:47:54 UTC
        

      






Created attachment 184280 [details]
Updated patch for 3.1.6 per Po-Chuan's comments

Simplified update patch.

    


    


      



        
          Comment 5
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2017-07-13 00:01:11 UTC
        

      






A commit references this bug:

Author: sunpoet
Date: Thu Jul 13 00:00:31 UTC 2017
New revision: 445623
URL: https://svnweb.freebsd.org/changeset/ports/445623

Log:
  Update to 3.1.6

  Changes:	https://pecl.php.net/package-changelog.php?package=pthreads
  PR:		220642
  Submitted by:	<amistry@am-productions.biz>
  Approved by:	John Chen <johnpupu@gmail.com> (maintainer)

Changes:
  head/devel/pecl-pthreads/Makefile
  head/devel/pecl-pthreads/distinfo
  head/devel/pecl-pthreads/pkg-descr

    


    


      



        
          Comment 6
        

        
          Po-Chuan Hsieh

        

        
            freebsd_committer
            freebsd_triage
        

        
          2017-07-13 00:02:33 UTC
        

      






Committed. Thanks!