Created attachment 184303 [details] diff to bring glusterfs port upto 3.11.1 version update glusterfs port to latest 3.11.1 version Makefile, patches, distinfo and pkg-plist modified... built against 11.0-RELEASE src and 11.1-RC2 https://reviews.freebsd.org/D11550
Created attachment 184304 [details] glusterfs 3.11.1 port tarball port tarball
I'm running a build test in 10.3, 11 and CURRENT (amd64,i386). And I think is better to wait a week or two for any feedbacks in your call for testing (freebsd-ports@), ok? And thank you for your efforts.
There are some issues to be fixed: ====> Running Q/A tests (stage-qa) Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'share/glusterfs/scripts/post-upgrade-script-for-quota.sh' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'share/glusterfs/scripts/eventsdash.py' Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'share/glusterfs/scripts/pre-upgrade-script-for-quota.sh' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/glusterfind' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/peer_eventsapi.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/events/glustereventsd.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/gfind_missing_files/gfid_to_path.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/glusterfind/changelog.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/glusterfind/brickfind.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/glusterfind/nodeagent.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'sbin/gcron.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'sbin/snap_scheduler.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/events/glustereventsd.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'libexec/glusterfs/peer_eventsapi.py' Warning: Bad symlink '/var/db/glusterd/hooks/1/delete/post/S57glusterfind-delete-post' pointing to an absolute pathname '/usr/local/libexec/glusterfs/glusterfind/S57glusterfind-delete-post.py' Warning: Bad symlink '/usr/local/sbin/glustereventsd' pointing to an absolute pathname '/usr/local/libexec/glusterfs/events/glustereventsd.py' Warning: Bad symlink '/usr/local/sbin/gluster-eventsapi' pointing to an absolute pathname '/usr/local/libexec/glusterfs/peer_eventsapi.py' Warning: Bad symlink '/usr/local/sbin/gfind_missing_files' pointing to an absolute pathname '/usr/local/libexec/glusterfs/gfind_missing_files/gfind_missing_files.sh' *** Error code 1 Stop. make: stopped in /usr/ports/net/glusterfs ====>> Error: stage-qa failures detected And you can remove the PORTREVISION line.
Danilo, I'm not sure /usr/bin/env python is incorrect.. I'll look at sorting the bash ones. As you can see from the diff we never had that many SHEBANG_FILES nor did we patch the scripts either. The port has never passed stage-qa. PORTREVISION is required for the little bumps that we make to the port outside of upstream. (3.9.0 got 3 minor updates) Happy waiting a week or two, I have made contact with folks using glusterfs for real in the wild to test, looking forward to their response. Kind Regards Craig Butler
Thanks for your great work! Please also checkout this patch: https://bugzilla.redhat.com/show_bug.cgi?id=1452961 @nfsmwlin will send this patch to review.gluster.org later.
Created attachment 184855 [details] glusterfs-3.11.1-20170730.patch Minor changes: Fix Q/A errors (shebangfix) Update WWW Use OPSYS with OSVERSION Could you take a look and make a final test? Regards.
Danilo patch looks fine... thanks do you think we need to role in Iblis patch (assuming it's still required in 3.11.1) ?? who can we get from fs@ to review and give the nod ?
(In reply to craig001 from comment #7) Not sure. This patch was already sent to review.gluster.org?
the latest patch is passing portlint and stage-qa building fine on 11.1-RC2 and 11-RELEASE amd64 glusterd and client appear to be working.
Its building fine in 10.3, 11 and 12-CURRENT (i386|amd64). Well, let's separate this. I'll push this update. After getting some feedback on review.gluster.org (about Iblis patch), open another PR to update here, and put me in the CC list. Sounds fine?
sounds like a great plan... thanks Danilo
A commit references this bug: Author: dbaio Date: Sun Jul 30 22:45:51 UTC 2017 New revision: 446944 URL: https://svnweb.freebsd.org/changeset/ports/446944 Log: net/glusterfs: Update to 3.11.1 - Regenerate patches While here: - Fix Q/A errors (shebangfix) - Update WWW - Use OPSYS with OSVERSION PR: 220674 Submitted by: craig001@lerwick.hopto.org (maintainer) Reviewed by: mat Differential Revision: https://reviews.freebsd.org/D11550 Changes: head/net/glusterfs/Makefile head/net/glusterfs/distinfo head/net/glusterfs/files/patch-configure head/net/glusterfs/files/patch-contrib-fuse-lib-mount.c head/net/glusterfs/files/patch-contrib_fuse-lib_mount.c head/net/glusterfs/files/patch-extras-Makefile.in head/net/glusterfs/files/patch-extras_Makefile.in head/net/glusterfs/pkg-descr head/net/glusterfs/pkg-plist
Committed, thanks for your work Craig.
(In reply to Danilo G. Baio from comment #8) @nfsmwlin sent it few minutes ago. https://review.gluster.org/#/c/17917