Bug 220753 - [exp-run] GStreamer update to 1.12.2
Summary: [exp-run] GStreamer update to 1.12.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koop Mast
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-07-16 08:21 UTC by Koop Mast
Modified: 2017-07-22 11:56 UTC (History)
2 users (show)

See Also:
kwm: exp-run?


Attachments
Gstreamer update 1.12.2 (99.00 KB, patch)
2017-07-16 08:21 UTC, Koop Mast
no flags Details | Diff
GStreamer 1.12.2 update rev.4 (93.19 KB, patch)
2017-07-16 18:01 UTC, Koop Mast
no flags Details | Diff
Gstreamer1 update 1.12.5. (96.14 KB, patch)
2017-07-18 17:32 UTC, Koop Mast
no flags Details | Diff
gstreamer update 1.12.2 rev. 6 (95.94 KB, patch)
2017-07-20 14:21 UTC, Koop Mast
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Koop Mast freebsd_committer 2017-07-16 08:21:29 UTC
Created attachment 184383 [details]
Gstreamer update 1.12.2

Exp-run for GStreamer 1.12.2..

I don't expect any issues but I just want to be sure due to me messing around with Mk/bsd.gstreamer.mk.
Comment 1 Koop Mast freebsd_committer 2017-07-16 08:22:47 UTC
Assign to portmgr for exp-run
Comment 2 Antoine Brodin freebsd_committer 2017-07-16 09:24:41 UTC
The patch fails to apply (problems with x11-toolkits/gstreamer1-plugins-gtk)
Comment 3 Koop Mast freebsd_committer 2017-07-16 18:01:23 UTC
Created attachment 184408 [details]
GStreamer 1.12.2 update rev.4

sigh, the -gtksink plugin was svn mv'd to just -gtk. And I didn't remember you need to call svn diff with --patch-compatible. Here the new version.
Comment 4 Antoine Brodin freebsd_committer 2017-07-17 20:08:09 UTC
Several ports are skipped:


"cannot install: unknown gstreamer 1.4 plugin -- mad" :
audio/clementine-player
audio/gnome-music
audio/lollypop
audio/pragha
x11/xpra


"cannot install: unknown gstreamer 1.4 plugin -- spc" :
multimedia/quodlibet
Comment 5 Koop Mast freebsd_committer 2017-07-18 17:32:01 UTC
Created attachment 184479 [details]
Gstreamer1 update 1.12.5.

In ports that use the mad plugin, replace it with mpg123 and bump portrevision.
Added the audio/gstreamer1-plugins-spc port

Remove commented out debug/test cruff from multimedia/gstreamer1-plugins-all, woops
Comment 6 Antoine Brodin freebsd_committer 2017-07-19 08:18:35 UTC
multimedia/quodlibet is ignored: "cannot install: unknown gstreamer 1.4 plugin -- mad"
Comment 7 Koop Mast freebsd_committer 2017-07-20 14:21:38 UTC
Created attachment 184547 [details]
gstreamer update 1.12.2 rev. 6

Changes:
Fix mad -> mpg123 gstreamer plugin in quodlibet.
Actualy remove the audio/gstreamer1-plugins-mad directory

Don't remove implicit gstreamer1 library dependancies, like in net-im/corebird and audio/gstreamer1-plugins-sndio, this will done after 1.12.2 commit and all ports that do this, in one go.
Comment 8 Antoine Brodin freebsd_committer 2017-07-21 09:59:38 UTC
Exp-run looks fine.

Is there a plan to remove gstreamer0 in the future?
Comment 9 Olivier Duchateau 2017-07-21 19:46:49 UTC
(In reply to Antoine Brodin from comment #8)

For the Xfce desktop, Parole (in devel release) uses only GStreamer1, and for Xfce's plugins or applications, they will be removed, because they are unmaintained for a long time.
Comment 10 Olivier Duchateau 2017-07-21 19:47:54 UTC
(In reply to duchateau.olivier from comment #9)

Oops, it's planned for the next stable 4.14.
Comment 11 commit-hook freebsd_committer 2017-07-22 11:36:06 UTC
A commit references this bug:

Author: kwm
Date: Sat Jul 22 11:35:46 UTC 2017
New revision: 446388
URL: https://svnweb.freebsd.org/changeset/ports/446388

Log:
  Update GStreamer1 ports to 1.12.2.

  Rework the adding of dependancies in Mk/bsd.gstreamer.mk.
  Previous when using USE_GSTREAMER[1] it would just add the request modules to BUILD/RUN_DEPENDS. This caused the qa script to complain because the old code didn't implicit depend on the gstreamer1 and gstreamer1-plugins[-bad] ports for the libraries they carried, even if they where present via the plugins! The new code adds implicit depends on these ports so USE_GSTREAMER[1] using ports have all the libraries included.

  * The mad mp3 plugin was removed, mpg123 plugin also provides mp3 decoding. Switch over ports that used the gstreamer1 mad plugin.
  * gtksink plugin renamed -> gtk
  * Hook up the sndio plugin into the framework
  * Add some indirect dependacies where needed
  * Reorder the plugin list in bsd.gstreamer.mk so only one plugin per line. When changing plugins it doesn't result in multiple lines being changed.
  * Remove mentions in bsd.gstreamer.mk of plugins mentions that where removed.
  * Depend on libunwind on i386/amd64, GStreamer links to it if it is present.

  PR:		220753
  Exp-run by:	antoine@

Changes:
  head/MOVED
  head/Mk/bsd.gstreamer.mk
  head/audio/Makefile
  head/audio/clementine-player/Makefile
  head/audio/gnome-music/Makefile
  head/audio/gstreamer1-plugins-chromaprint/Makefile
  head/audio/gstreamer1-plugins-ladspa/
  head/audio/gstreamer1-plugins-ladspa/Makefile
  head/audio/gstreamer1-plugins-mad/
  head/audio/gstreamer1-plugins-musepack/
  head/audio/gstreamer1-plugins-musepack/Makefile
  head/audio/gstreamer1-plugins-sndfile/
  head/audio/gstreamer1-plugins-sndfile/Makefile
  head/audio/gstreamer1-plugins-spc/
  head/audio/gstreamer1-plugins-spc/Makefile
  head/audio/lollypop/Makefile
  head/audio/pragha/Makefile
  head/graphics/Makefile
  head/graphics/gstreamer1-plugins-gl/Makefile
  head/graphics/gstreamer1-plugins-gl/pkg-plist
  head/graphics/gstreamer1-plugins-kms/
  head/graphics/gstreamer1-plugins-kms/Makefile
  head/graphics/gstreamer1-plugins-opencv/Makefile
  head/graphics/gstreamer1-plugins-opencv/pkg-plist
  head/graphics/gstreamer1-plugins-openexr/
  head/graphics/gstreamer1-plugins-openexr/Makefile
  head/graphics/gstreamer1-plugins-webp/Makefile
  head/multimedia/Makefile
  head/multimedia/gstreamer1/Makefile
  head/multimedia/gstreamer1/distinfo
  head/multimedia/gstreamer1/pkg-plist
  head/multimedia/gstreamer1-editing-services/Makefile
  head/multimedia/gstreamer1-editing-services/distinfo
  head/multimedia/gstreamer1-editing-services/pkg-plist
  head/multimedia/gstreamer1-libav/Makefile
  head/multimedia/gstreamer1-libav/distinfo
  head/multimedia/gstreamer1-plugins/Makefile
  head/multimedia/gstreamer1-plugins/Makefile.common
  head/multimedia/gstreamer1-plugins/distinfo
  head/multimedia/gstreamer1-plugins/files/patch-gst_audioresample_float.c
  head/multimedia/gstreamer1-plugins/files/patch-gst_audioresample_resample.c
  head/multimedia/gstreamer1-plugins/files/patch-gst_audioresample_speex-resampler-double.c
  head/multimedia/gstreamer1-plugins/pkg-plist
  head/multimedia/gstreamer1-plugins-all/Makefile
  head/multimedia/gstreamer1-plugins-assrender/Makefile
  head/multimedia/gstreamer1-plugins-bad/Makefile
  head/multimedia/gstreamer1-plugins-bad/files/
  head/multimedia/gstreamer1-plugins-bad/pkg-plist
  head/multimedia/gstreamer1-plugins-core/Makefile
  head/multimedia/gstreamer1-plugins-dash/
  head/multimedia/gstreamer1-plugins-dash/Makefile
  head/multimedia/gstreamer1-plugins-good/Makefile
  head/multimedia/gstreamer1-plugins-good/pkg-plist
  head/multimedia/gstreamer1-plugins-mplex/
  head/multimedia/gstreamer1-plugins-mplex/Makefile
  head/multimedia/gstreamer1-plugins-openh264/Makefile
  head/multimedia/gstreamer1-plugins-smoothstreaming/
  head/multimedia/gstreamer1-plugins-smoothstreaming/Makefile
  head/multimedia/gstreamer1-plugins-ttml/
  head/multimedia/gstreamer1-plugins-ttml/Makefile
  head/multimedia/gstreamer1-plugins-ugly/pkg-plist
  head/multimedia/gstreamer1-plugins-vpx/Makefile
  head/multimedia/gstreamer1-plugins-x264/Makefile
  head/multimedia/gstreamer1-rtsp-server/Makefile
  head/multimedia/gstreamer1-rtsp-server/distinfo
  head/multimedia/gstreamer1-vaapi/Makefile
  head/multimedia/gstreamer1-vaapi/distinfo
  head/multimedia/gstreamer1-vaapi/pkg-plist
  head/multimedia/gstreamer1-validate/Makefile
  head/multimedia/gstreamer1-validate/distinfo
  head/multimedia/gstreamer1-validate/pkg-plist
  head/multimedia/py-gstreamer1/Makefile
  head/multimedia/py-gstreamer1/distinfo
  head/multimedia/py3-gstreamer1/Makefile
  head/multimedia/py3-gstreamer1/distinfo
  head/multimedia/quodlibet/Makefile
  head/net/Makefile
  head/net/gstreamer1-plugins-srtp/
  head/net/gstreamer1-plugins-srtp/Makefile
  head/net-im/corebird/Makefile
  head/security/gstreamer1-plugins-dtls/Makefile
  head/sysutils/gstreamer1-plugins-cdio/Makefile
  head/sysutils/mate-control-center/pkg-plist
  head/x11/xpra/Makefile
  head/x11-toolkits/Makefile
  head/x11-toolkits/gstreamer1-plugins-gtk/
  head/x11-toolkits/gstreamer1-plugins-gtk/Makefile
  head/x11-toolkits/gstreamer1-plugins-gtksink/
Comment 12 Koop Mast freebsd_committer 2017-07-22 11:56:55 UTC
I don't have a plan yet to work on removing GStreamer 0.10 yet.

A quick look shows that it shouldn't be too hard. I think we should wait until the next xfce update comes out where they switch to the newer version. Apart from that x11-toolkits/wxgtk28 is going to be a nice one to deal with.