Created attachment 184457 [details] synth port patches Updates for synth: 1. Add option (enabled by default) to disable the timeout watchdog, as agreed with the author. https://github.com/jrmarino/synth/issues/53#issuecomment-293621998 2. Add upstream patch for aarch64 platform recognition https://github.com/jrmarino/synth/pull/82
I just got a notification from Marino that 1.70 is out.
Created attachment 184603 [details] synth-1.70 with NOWATCHDOG option I've updated the patch to accomodate 1.70
thanks
Comment on attachment 184603 [details] synth-1.70 with NOWATCHDOG option @Eric, would appreciate if you could set this flag to + to signify maintainer approval
Still pending QA (poudriere in particular)
I already flag it as +.
Note the distinction between maintainer-feedback flag (at the issue level) and maintainer-approval flag (at the attachment/patch level) which is used to approve patches
(In reply to Kubilay Kocak from comment #5) How can I progress this? Is it with me or you, Kubilay?
(In reply to Jonathan Chen from comment #8) Nothing further appears to be required to progress, pending a committer assigning themselves.
A commit references this bug: Author: matthew Date: Tue Jul 25 16:20:05 UTC 2017 New revision: 446594 URL: https://svnweb.freebsd.org/changeset/ports/446594 Log: Update to 1.70 Add NOWATCHDOG option PR: 220812 Submitted by: jonc@chen.org.nz Approved by: ericturgeon.bsd@gmail.com (maintainer) Changes: head/ports-mgmt/synth/Makefile head/ports-mgmt/synth/distinfo head/ports-mgmt/synth/files/ head/ports-mgmt/synth/files/extrapatch-nowatchdog-portscan-buildcycle.adb
Committed, thanks!
Shouldn't the NOWATCHDOG option be off by default, per the author's comment? https://github.com/jrmarino/synth/issues/53#issuecomment-293621998 "If you want to propose a change to the port to give it an option to build with the watchdog on (off by default), you have my blessing."
Never mind -- sorry for the spam. I think I had trouble parsing whether the author was actually in favor of the watchdog being on or off by default, given his ambivalence on the subject.
The author wants the port to have the watchdog _disabled_ by default. Since the code enables the watchdog on as is, it was easier to have a patch that would disable it, and have it applied by default. If you read the github thread, this is in response to long builds without output that are terminated prematurely.