Created attachment 184495 [details] Patch Changes: https://github.com/fanglingsu/vimb/compare/2.11...2.12 Vimb - the vim like browser is a completely keyboard-driven, so enable FEATURE_NO_SCROLLBARS as is enabled by default.
Hi, thanks for the input, I have made the updates a long ago, along with optional HTML5 depends: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218733 Currently I'm preparing the port of vimb 3.x which is based on webkit2, but it behaves drunk on my hardware, so I have no motivation to finish. As of scrollbars, I vaguely remember some sites detecting the screen width incorrectly. Anyway, you guys decide.
(In reply to Michael Danilov from comment #1) Hi Mike, thanks for the feedback. I did builded and try to use vimb-3.0.alpha, but it a bit slowly on my hardware, have many bugs and lack of some functions. So I think 3.0.alpha is not ready for regular use. As vimb-3.0 will be ready - we can create new port vimb3 or move existing ports to vimb2-gtk2 and vimb2-gtk3 for users who wants to use them. About scrollbars. Can we create option HIDE_SCROLLBARS and pass -DFEATURE_NO_SCROLLBARS to build env if user select this? I tested patch from 218733, is worked well for me. We have commiter here and can incorporate patches and close 218733 and this issues.
Created attachment 184530 [details] Patch v2 Merge HTML5 video support from 218733 by Michael Danilov. Add option to disable scrollbars.
*** Bug 218733 has been marked as a duplicate of this bug. ***
Created attachment 184544 [details] portlint -AC
Created attachment 184545 [details] www/vimb-gtk2 I forgot. One is supposed to use port.post.mk if port.pre.mk is included.
Created attachment 184546 [details] poudriere testport
(In reply to Michael Danilov from comment #6) Thanks for fixing this. How I can mark my patch as obsolete?
Hm, I can't seem to find the option either. Maybe by uploading a dummy file then.
Hi Mike, I have some erros while run tests. Can you please fix them? ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/vimb is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency Warning: you need USE_GNOME+=cairo Error: /usr/local/bin/vimb is linked to /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it is not declared as a dependency Warning: you need USE_GNOME+=gdkpixbuf2 Error: /usr/local/bin/vimb is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig Error: /usr/local/bin/vimb is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2 Error: /usr/local/bin/vimb is linked to /usr/local/lib/libsoup-2.4.so.1 from devel/libsoup but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libsoup-2.4.so:devel/libsoup
@Oleh You may enable extra sanity checks and testing procedures (such as those mentioned in comment 10) by adding DEVELOPER=yes to /etc/make.conf
Created attachment 184626 [details] Patch v3 Fixed test-qa errors.
(In reply to Kubilay Kocak from comment #11) Enabled, thanks!
Created attachment 184697 [details] poudriere testport Hi, Sorry about the delay, had to handle a couple interrupts. I'm wondering how I can enable DEVELOPER in make.conf for poudriere testport only -- because I remember that if I enable it on my production jail, the non-build times are are much longer. Thank you for the improvements, Mike
A commit references this bug: Author: ultima Date: Tue Aug 1 22:31:43 UTC 2017 New revision: 447081 URL: https://svnweb.freebsd.org/changeset/ports/447081 Log: * Updated to 2.12 * Added LICENSE_FILE * Moved USES to start the section block * Sorted option section to better comply with PHB Changelog: https://github.com/fanglingsu/vimb/compare/2.11...2.12 PR: 220848 Submitted by: Oleh Hushchenkov <gor@clogic.com.ua> Reviewed by: lifanov (mentor), mat, Michael Danilov <mike.d.ft402@gmail.com> (maintainer) Approved by: lifanov (mentor), Michael Danilov <mike.d.ft402@gmail.com> (maintainer) Differential Revision: https://reviews.freebsd.org/D11799 Changes: head/www/vimb-gtk2/Makefile head/www/vimb-gtk2/distinfo head/www/vimb-gtk2/files/patch-config.mk head/www/vimb-gtk2/files/patch-src_config.h
Committed, thanks!