Bug 220851 - dns/knot2: Correct /var/{db,run}/knot owner
Summary: dns/knot2: Correct /var/{db,run}/knot owner
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthew Seaman
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-19 11:59 UTC by Sascha Holzleiter
Modified: 2017-07-19 12:53 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)
koobs: merge-quarterly?

Attachments
knot2 pkg-plist patch to fix dir ownership (307 bytes, patch)
2017-07-19 11:59 UTC, Sascha Holzleiter 		no flags Details | Diff
knot2 update (687 bytes, patch)
2017-07-19 12:46 UTC, Leo Vandewoestijne 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2017-07-19 11:59:12 UTC 
Created attachment 184502 [details]
knot2 pkg-plist patch to fix dir ownership

Installing the current port installs /var/run/knot and /var/db/knot as owned by root:wheel. This small pkg-plist patch should correct that.
Comment 1 Leo Vandewoestijne 2017-07-19 12:46:14 UTC 
Created attachment 184504 [details]
knot2 update

Nice improvement, thanks!
I've added PORTREVISION=1
Tested against i386/amd64 on 10.3/11.0/12.0 (but with such minor difference of course the result remained all OK).
Comment 2 Leo Vandewoestijne 2017-07-19 12:50:55 UTC 
Comment on attachment 184502 [details]
knot2 pkg-plist patch to fix dir ownership

Sacha's patch was merged with Leo's, which added PORTREVISION.
Comment 3 Matthew Seaman freebsd_committer freebsd_triage 2017-07-19 12:53:09 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-07-19 12:53:52 UTC 
A commit references this bug:

Author: matthew
Date: Wed Jul 19 12:52:52 UTC 2017
New revision: 446197
URL: https://svnweb.freebsd.org/changeset/ports/446197

Log:
  Fix the ownership of /var/db/knot and /var/run/knot

  PR:		220851
  Submitted by:	sascha@root-login.org
  Approved by:	freebsd@dns-lab.com (maintainer)

Changes:
  head/dns/knot2/Makefile
  head/dns/knot2/pkg-plist