Bug 220975 - editors/abiword: Fails to build with GRAMMAR option enabled (update to 3.0.2 )
Summary: editors/abiword: Fails to build with GRAMMAR option enabled (update to 3.0.2 )
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-24 18:57 UTC by Grzegorz Junka
Modified: 2019-08-09 13:25 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)
koobs: merge-quarterly?


Attachments
test-svn-diff-update-abiword-3.0.2 (15.64 KB, patch)
2018-02-13 19:20 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-abiword_v2 (23.67 KB, patch)
2018-09-30 19:13 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-abiword_v3 (2.81 KB, patch)
2018-12-22 04:32 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-abiword_v4 (13.96 KB, patch)
2018-12-22 04:44 UTC, Walter Schwarzenfeld
no flags Details | Diff
Patches updated to build on current ports tree in 12-RELEASE. (50.77 KB, patch)
2019-04-04 02:29 UTC, ralph
no flags Details | Diff
svn-diff-abiword-3.0.2 (23.70 KB, patch)
2019-04-04 03:02 UTC, ralph
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Junka 2017-07-24 18:57:21 UTC
Build fails when the grammar option is enabled

# This file is auto-generated by 'make config'.
# Options for abiword-3.0.1_1
_OPTIONS_READ=abiword-3.0.1_1
_FILE_COMPLETE_OPTIONS_LIST=AIKSAURUS CLIPART DEBUG MATHVIEW NLS OTS PSION TEMPLATES WP GRAMMAR SPELLCHECK COLFAKE COLSERVICE COLSIP COLSUGAR COLTCP COLTELEPATHY COLXMPP
OPTIONS_FILE_UNSET+=AIKSAURUS
OPTIONS_FILE_SET+=CLIPART
OPTIONS_FILE_UNSET+=DEBUG
OPTIONS_FILE_SET+=MATHVIEW
OPTIONS_FILE_SET+=NLS
OPTIONS_FILE_SET+=OTS
OPTIONS_FILE_UNSET+=PSION
OPTIONS_FILE_SET+=TEMPLATES
OPTIONS_FILE_SET+=WP
OPTIONS_FILE_SET+=GRAMMAR
OPTIONS_FILE_SET+=SPELLCHECK
OPTIONS_FILE_UNSET+=COLFAKE
OPTIONS_FILE_UNSET+=COLSERVICE
OPTIONS_FILE_UNSET+=COLSIP
OPTIONS_FILE_UNSET+=COLSUGAR
OPTIONS_FILE_UNSET+=COLTCP
OPTIONS_FILE_UNSET+=COLTELEPATHY
OPTIONS_FILE_UNSET+=COLXMPP


LinkGrammarWrap.Tpo -c LinkGrammarWrap.cpp  -fPIC -DPIC -o .libs/LinkGrammarWrap.o
LinkGrammarWrap.cpp:90:3: error: use of undeclared identifier 'parse_options_set_panic_mode'; did you mean 'parse_options_set_max_memory'?
  parse_options_set_panic_mode(m_Opts, TRUE);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  parse_options_set_max_memory
/usr/local/include/link-grammar/link-includes.h:171:6: note: 'parse_options_set_max_memory' declared here
     parse_options_set_max_memory(Parse_Options  opts, int mem);
     ^
LinkGrammarWrap.cpp:148:41: error: use of undeclared identifier 'sentence_get_nth_word'
          pWordMap->m_iErrHigh = iLow + strlen(sentence_get_nth_word(sent, i));
                                               ^
LinkGrammarWrap.cpp:152:8: error: use of undeclared identifier 'sentence_nth_word_has_disjunction'
          if(!sentence_nth_word_has_disjunction(sent, i))
              ^
LinkGrammarWrap.cpp:170:30: error: use of undeclared identifier 'sentence_get_nth_word'
              iHigh = iLow + strlen(sentence_get_nth_word(sent, i));
                                    ^
LinkGrammarWrap.cpp:191:30: error: use of undeclared identifier 'sentence_get_nth_word'
              iHigh = iLow + strlen(sentence_get_nth_word(sent, i)) + iOff;
                                    ^
LinkGrammarWrap.cpp:200:19: error: use of undeclared identifier 'sentence_get_nth_word'
          iLow += strlen(sentence_get_nth_word(sent, i));
                         ^
LinkGrammarWrap.cpp:232:20: error: use of undeclared identifier 'linkage_get_num_sublinkages'; did you mean 'linkage_get_num_links'?
        UT_sint32 count = linkage_get_num_sublinkages(linkage);
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                          linkage_get_num_links
/usr/local/include/link-grammar/link-includes.h:296:6: note: 'linkage_get_num_links' declared here
     linkage_get_num_links(const Linkage linkage);
     ^
LinkGrammarWrap.cpp:238:20: error: use of undeclared identifier 'linkage_set_current_sublinkage'
          UT_sint32 iok = linkage_set_current_sublinkage(linkage, i);
                          ^
8 errors generated.
gmake[5]: *** [Makefile:569: LinkGrammarWrap.lo] Error 1
gmake[5]: Leaving directory '/wrkdirs/usr/ports/editors/abiword/work/abiword-3.0.1/plugins/grammar/linkgrammarwrap'
gmake[4]: *** [Makefile:678: all-recursive] Error 1
gmake[4]: Leaving directory '/wrkdirs/usr/ports/editors/abiword/work/abiword-3.0.1/plugins/grammar'
gmake[3]: *** [Makefile:528: all-recursive] Error 1
gmake[3]: Leaving directory '/wrkdirs/usr/ports/editors/abiword/work/abiword-3.0.1/plugins'
gmake[2]: *** [Makefile:774: all-recursive] Error 1
gmake[2]: Leaving directory '/wrkdirs/usr/ports/editors/abiword/work/abiword-3.0.1'
gmake[1]: *** [Makefile:593: all] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/editors/abiword/work/abiword-3.0.1'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/editors/abiword

Full log attached
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2017-07-24 21:26:56 UTC
Make Summary more verbose.
Comment 2 Grzegorz Junka 2018-01-13 13:04:25 UTC
Do you mean I should put a more verbose option to the compilation or explain more clearly that the build fails when this particular option is enabled?
Comment 3 Grzegorz Junka 2018-01-13 13:05:16 UTC
Ah, ok, sorry, didn't see your next comment as I was logged out.
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-02-13 19:20:13 UTC
Created attachment 190587 [details]
test-svn-diff-update-abiword-3.0.2

This is a try to update abiword to 3.0.2. Builds on 10.4 und 11.1 fine. Starts normal (except the standard zoom is to big at first start - needs changed to 100%9). Needs runtest.

ChangeLog:
https://www.abisource.com/release-notes/3.0.2.phtml
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-02-13 19:21:18 UTC
This also compiles with GRAMMAR=on.
Comment 6 Greg V 2018-03-30 14:48:34 UTC
(In reply to w.schwarzenfeld from comment #5)

Thanks for the patch. In addition to it, I had to

- delete the *DocumentRDF patches that didn't apply
- add CXXFLAGS+=-std=c++98 (since you deleted the C++11 patch)

and now it works fine on 12-CURRENT.
Comment 7 Walter Schwarzenfeld freebsd_triage 2018-03-30 15:44:03 UTC
I have no 12.0, so I overlooked the c++11 patch. Can you try to add a patch to mine? Next days I don't really I have time to look in it.
Comment 8 Greg V 2018-03-30 16:06:39 UTC
(In reply to w.schwarzenfeld from comment #7)
I think adding CXXFLAGS+=-std=c++98 is actually better than recreating that patch. We don't gain anything from compiling in C++11/17 mode, the code is valid C++98, let's just tell the compiler that it's C++98.
Comment 9 Charlie Li 2018-05-28 07:12:12 UTC
I've rolled up both the initial patch and subsequent comments into a pull request on gnome@'s devel git repository. I've also removed the NLS option as not only is the configure option deprecated (manifested as unknown option warning) but gettext is not needed. Passes testport.

https://github.com/freebsd/freebsd-ports-gnome/pull/11
Comment 10 Charlie Li 2018-07-06 18:34:51 UTC
(In reply to Charlie Li from comment #9)
Now at https://github.com/freebsd/freebsd-ports-gnome/pull/13 . No changes to the patch.
Comment 11 Walter Schwarzenfeld freebsd_triage 2018-09-30 18:16:20 UTC
New error:
use of undeclared identifier 'icaltime_from_timet' (pd_DocumentRDF.cpp)

There is a patch:
https://www.mail-archive.com/arch-commits@archlinux.org/msg381957.html
libical-deprecated.patch
Comment 12 Walter Schwarzenfeld freebsd_triage 2018-09-30 19:13:12 UTC
Created attachment 197643 [details]
svn-diff-abiword_v2

Updated patch including ical-patch.
Comment 13 Walter Schwarzenfeld freebsd_triage 2018-12-22 04:32:15 UTC
Created attachment 200348 [details]
svn-diff-abiword_v3

Update patch after ports r488056.
Comment 14 Walter Schwarzenfeld freebsd_triage 2018-12-22 04:44:32 UTC
Created attachment 200349 [details]
svn-diff-abiword_v4

Attached a wrong svn-diff.
Comment 15 ralph 2019-04-04 02:29:40 UTC
Created attachment 203361 [details]
Patches updated to build on current ports tree in 12-RELEASE.
Comment 16 ralph 2019-04-04 03:02:59 UTC
Created attachment 203363 [details]
svn-diff-abiword-3.0.2

Cleaned up patch-configure
Comment 17 Walter Schwarzenfeld freebsd_triage 2019-08-07 22:33:09 UTC
One and a half year and no reaction from gnome! Reset Maintainer.