Bug 221154 - [NEW PORT] mail/py-premailer: Convert CSS to style attributes
Summary: [NEW PORT] mail/py-premailer: Convert CSS to style attributes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-01 16:03 UTC by Ryder Dain
Modified: 2017-10-14 07:22 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
port shar (1.96 KB, text/plain)
2017-08-01 16:03 UTC, Ryder Dain 		no flags Details
Updated py-premailer.shar file (2.00 KB, text/plain)
2017-08-06 08:46 UTC, Ryder Dain 		no flags Details
Update py-premailer.shar file's pkg-descr (2.04 KB, text/plain)
2017-09-19 08:08 UTC, Ryder Dain 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryder Dain 2017-08-01 16:03:35 UTC 
Created attachment 184918 [details]
port shar

Python module for converting CSS to use in HTML email.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-02 04:15:21 UTC 
Thank you for contributing a new FreeBSD port Ryder.

Please:

- Add LICENSE_FILE pointing to ${WRKSRC}/path/to/licensefile when one exists in the distribution file (premailer provides one called LICENSE)

- Confirm this port passes QA (portlint and poudriere in particular). For more information and testing instruction see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html

Note also:

Setting the maintainer-feedback flag is not required for new ports, as uncommitted ports have no maintainer until committed by definition.

This also applies to the maintainer-approval flag on attachments
Comment 2 Ryder Dain 2017-08-06 08:46:56 UTC 
Created attachment 185081 [details]
Updated py-premailer.shar file

Updated to include LICENSE_FILE= ${WRKSRCZ}/LICENSE as requested.

Can also confirm that this passed portlint, as well as porttools tests.
Comment 3 Richard Gallamore freebsd_committer freebsd_triage 2017-08-12 00:58:01 UTC 
Everything looks good except there is no WWW at the end of the pkg-descr. Please add the most common one to the end of pkg-descr.

https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-desc
Comment 4 Ryder Dain 2017-09-19 08:08:05 UTC 
Created attachment 186530 [details]
Update py-premailer.shar file's pkg-descr

Thanks for the support, Richard. Supplying author's github to port as source.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2017-10-14 07:21:18 UTC 
Committed, thanks.

Please note:
- shar had wrong lineendings
- Makefile had spaces instead of tabs, so portlint complained
- pkg-descr had no empty line between text and WWW: field
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-10-14 07:22:08 UTC 
A commit references this bug:

Author: pi
Date: Sat Oct 14 07:21:17 UTC 2017
New revision: 452046
URL: https://svnweb.freebsd.org/changeset/ports/452046

Log:
  New port: mail/py-premailer: Convert CSS to style attributes

  Python module to support CSS and HTML-based email formatting.

  WWW: https://github.com/peterbe/premailer

  PR:		221154
  Submitted by:	Ryder Dain <ryder.dain@gmail.com>

Changes:
  head/mail/Makefile
  head/mail/py-premailer/
  head/mail/py-premailer/Makefile
  head/mail/py-premailer/distinfo
  head/mail/py-premailer/pkg-descr