Bug 221312 - databases/pgpool-II-36: unable to configure the stop command
Summary: databases/pgpool-II-36: unable to configure the stop command
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-07 14:13 UTC by chad.schroeder
Modified: 2018-04-17 09:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (tz)

Attachments
Patch to allow configuration of stop mode (865 bytes, patch)
2018-02-21 11:28 UTC, Torsten Zuehlsdorff 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chad.schroeder 2017-08-07 14:13:39 UTC 
With the current rc.d/pgpool service script, a user is unable to configure the stop command, via rc.conf, with stop options, e.g.

  -m, --mode=SHUTDOWN-MODE
                      Can be "smart", "fast", or "immediate"
Comment 1 Walter Schwarzenfeld 2018-02-08 21:24:36 UTC 
Feedback please!
Comment 2 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2018-02-21 11:28:19 UTC 
Created attachment 190854 [details]
Patch to allow configuration of stop mode

Aloha,

i'm sorry it took so long. Attached a patch which should enable your feature request. You can add pgpool_stop_mode in /etc/rc.conf to modify stop mode.

Can you please verify it?

Greetings,
Torsten
Comment 3 chad.schroeder 2018-02-23 14:32:17 UTC 
Thanks for the update.  I don't have the bandwidth to vet it out right now, but the patch looks like it will appropriately address the issue.
Comment 4 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2018-03-23 10:19:38 UTC 
Aloha,

did you find some time for testing the patch?

Greetings,
Torsten
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-04-17 09:09:14 UTC 
A commit references this bug:

Author: tz
Date: Tue Apr 17 09:08:34 UTC 2018
New revision: 467584
URL: https://svnweb.freebsd.org/changeset/ports/467584

Log:
  databases/pgpool-II-36: allow configuration of stop_mode

  PR: 221312

Changes:
  head/databases/pgpool-II-36/files/pgpool.in