Bug 221688 - net/czmq: Fails to build due to -Werror flags after libzmq 4.2.2 update
Summary: net/czmq: Fails to build due to -Werror flags after libzmq 4.2.2 update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2017-08-21 10:09 UTC by Jan Bramkamp
Modified: 2017-08-21 10:40 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Bramkamp 2017-08-21 10:09:12 UTC 
Building czmq 3.0.2_1 on FreeBSD 11.1/amd64 in poudriere ends with this error message:

===>  Building for czmq-3.0.2_1
Making all in doc
/bin/sh ./libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I./src  -I/usr/local/include  -I./include -pedantic -Werror -Wall -Wc++-compat -D__BSD_VISIBLE -D_REENTRANT -D_THREAD_SAFE  -O2 -pipe  -fstack-protector -fno-strict-aliasing -MT src/src_libczmq_la-zactor.lo -MD -MP -MF src/.deps/src_libczmq_la-zactor.Tpo -c -o src/src_libczmq_la-zactor.lo `test -f 'src/zactor.c' || echo './'`src/zactor.c
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I./src -I/usr/local/include -I./include -pedantic -Werror -Wall -Wc++-compat -D__BSD_VISIBLE -D_REENTRANT -D_THREAD_SAFE -O2 -pipe -fstack-protector -fno-strict-aliasing -MT src/src_libczmq_la-zactor.lo -MD -MP -MF src/.deps/src_libczmq_la-zactor.Tpo -c src/zactor.c  -fPIC -DPIC -o src/.libs/src_libczmq_la-zactor.o
In file included from src/zactor.c:34:
In file included from ./src/../include/czmq.h:30:
In file included from ./include/czmq_library.h:24:
In file included from ./include/czmq_prelude.h:210:
/usr/local/include/zmq_utils.h:40:32: error: unknown warning group '-Wcpp', ignored [-Werror,-Wunknown-pragmas]
#pragma GCC diagnostic warning "-Wcpp"
                               ^
/usr/local/include/zmq_utils.h:41:32: error: unknown warning group '-Werror', ignored [-Werror,-Wunknown-pragmas]
#pragma GCC diagnostic ignored "-Werror"
                               ^
/usr/local/include/zmq_utils.h:44:9: warning: Warning: zmq_utils.h is deprecated. All its functionality is provided by zmq.h. [-W#pragma-messages]
#pragma message("Warning: zmq_utils.h is deprecated. All its functionality is provided by zmq.h.")
        ^
1 warning and 2 errors generated.
*** Error code 1

Stop.
make[2]: stopped in /wrkdirs/usr/ports/net/czmq/work/czmq-3.0.2
*** Error code 1

Stop.
make[1]: stopped in /wrkdirs/usr/ports/net/czmq/work/czmq-3.0.2
*** Error code 1

Stop.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-21 10:19:41 UTC 
tldr: czmq needs its -werror flag overridden (done in net/libzmq* already).

Stand by.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-21 10:36:14 UTC 
A commit references this bug:

Author: koobs
Date: Mon Aug 21 10:35:43 UTC 2017
New revision: 448460
URL: https://svnweb.freebsd.org/changeset/ports/448460

Log:
  net/czmq: Squash -Werror flag

  zmq_utils.h functionality was moved to zmq.h since 4.2.0, with a deprecation
  warning added. ports r448376 updated libzm4 to 4.2.2, which caused a build error
  in net/cmzq due to the -Werror flag (set by default):

    /usr/local/include/zmq_utils.h:41:32: error: unknown warning group '-Werror', ignored [-Werror,-Wunknown-warning-option]
    #pragma GCC diagnostic ignored "-Werror"
                                   ^
    /usr/local/include/zmq_utils.h:44:9: warning: Warning: zmq_utils.h is deprecated. All its functionality is provided by zmq.h. [-W#pragma-messages]
    #pragma message("Warning: zmq_utils.h is deprecated. All its functionality is provided by zmq.h.")
            ^

  Squash the -Werror flag (as done in net/libzmq4) accordingly.

  While I'm here:

  - Modernize test target
  - Group build related entries (MAKE_ENV/CPPFLAGS)

  PR:		221688
  Reported by:	olgeni, Jan Bramkamp <crest_maintainer rlwinm de>
  MFH:		2017Q3

Changes:
  head/net/czmq/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-21 10:39:19 UTC 
A commit references this bug:

Author: koobs
Date: Mon Aug 21 10:38:43 UTC 2017
New revision: 448461
URL: https://svnweb.freebsd.org/changeset/ports/448461

Log:
  MFH: r448460

  net/czmq: Squash -Werror flag

  zmq_utils.h functionality was moved to zmq.h since 4.2.0, with a deprecation
  warning added. ports r448376 updated libzm4 to 4.2.2, which caused a build error
  in net/cmzq due to the -Werror flag (set by default):

    /usr/local/include/zmq_utils.h:41:32: error: unknown warning group '-Werror', ignored [-Werror,-Wunknown-warning-option]
    #pragma GCC diagnostic ignored "-Werror"
                                   ^
    /usr/local/include/zmq_utils.h:44:9: warning: Warning: zmq_utils.h is deprecated. All its functionality is provided by zmq.h. [-W#pragma-messages]
    #pragma message("Warning: zmq_utils.h is deprecated. All its functionality is provided by zmq.h.")
            ^

  Squash the -Werror flag (as done in net/libzmq4) accordingly.

  While I'm here:

  - Modernize test target
  - Group build related entries (MAKE_ENV/CPPFLAGS)

  PR:		221688
  Reported by:	olgeni, Jan Bramkamp <crest_maintainer rlwinm de>

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/net/czmq/Makefile
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-21 10:40:31 UTC 
Committed and merged (to quarterly). Apologies for the noise, thank you kindly for the reports :)