Bug 221725 - net/rsync: use https master site
Summary: net/rsync: use https master site
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-22 18:58 UTC by Johannes Jost Meixner
Modified: 2017-09-17 13:13 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
encryption is good (666 bytes, patch)
2017-08-22 18:58 UTC, Johannes Jost Meixner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer 2017-08-22 18:58:58 UTC
Created attachment 185673 [details]
encryption is good

- use https master site
Comment 1 Emanuel Haupt freebsd_committer 2017-08-27 06:58:54 UTC
The porters handbook doesn't state anything specifically about using HTTPS MASTER_SITES to this day but it has always been best practice to avoid them or at least have a HTTP site in there for people behind evil proxies. I share your sentiment that "encryption is good" but the integrity of the distfiles is guaranteed hhe SHA256 checksums in the distinfo file. If the HTTP sites would redirect to HTTPS this would justify replacing the HTTP sites but this is not the case. I suggest either leaving it as is or just adding the HTTPS sites without removing the HTTP ones. Feel free to commit either of the two options.
Comment 2 Emanuel Haupt freebsd_committer 2017-09-17 13:13:40 UTC
I've added HTTPS alternatives.
Comment 3 commit-hook freebsd_committer 2017-09-17 13:13:50 UTC
A commit references this bug:

Author: ehaupt
Date: Sun Sep 17 13:13:11 UTC 2017
New revision: 449999
URL: https://svnweb.freebsd.org/changeset/ports/449999

Log:
  - Remove unavailable MASTER_SITES
  - Add HTTPS alternatives by request [1], deliberately keep corresponding HTTP
    hosts for providing a variety of sources (not for integrity since this is
    guaranteed by the distinfo checksums)

  PR:		221725 [1]
  Submitted by:	xmj [1]

Changes:
  head/net/rsync/Makefile