Bug 221784 - [sysutils/p5-File-Stat-Bits] Failed for p5-File-Stat-Bits-1.01_1 in build/runaway
Summary: [sysutils/p5-File-Stat-Bits] Failed for p5-File-Stat-Bits-1.01_1 in build/run...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-perl (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-25 03:10 UTC by Jim Pirzyk
Modified: 2019-01-08 12:56 UTC (History)
3 users (show)

See Also:

Attachments
Build system mail message (45.49 KB, application/pdf)
2017-08-25 03:10 UTC, Jim Pirzyk 		no flags Details
patch (1.46 KB, patch)
2017-10-22 15:10 UTC, Mikael Urankar 		no flags Details | Diff
patch (2.06 KB, patch)
2017-10-23 15:31 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Pirzyk freebsd_committer freebsd_triage 2017-08-25 03:10:30 UTC 
Created attachment 185737 [details]
Build system mail message

Getting mail from the build system saying this port is failing on FreeBSD-12.0

But in the mail it has this:

!!! Jail is newer than host. (Jail: 1200041, Host: 1200040) !!!
!!! This is not supported. !!!
!!! Host kernel must be same or newer than jail. !!!
!!! Expect build failures. !!!

and later it has this:

=======================<phase: build          >============================
===>  Building for p5-File-Stat-Bits-1.01_1
cp Bits.pm blib/lib/File/Stat/Bits.pm
<sys/sysmacros.h> absent
major/minor present
====>> Killing runaway build after 7200 seconds with no output

It builds fine in my 11.1-RELEASE-p1 environment, I do not have access to a 12.0-RELEASE environment.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2017-08-25 09:50:57 UTC 
fwiw the port fails across 3 different machines, all on -head.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2017-08-25 09:55:27 UTC 
Over to perl@
Comment 3 Jim Pirzyk freebsd_committer freebsd_triage 2017-08-25 11:19:52 UTC 
Still seems to me an infrastructure issue because of this:

!!! Jail is newer than host. (Jail: 1200041, Host: 1200040) !!!
!!! This is not supported. !!!
!!! Host kernel must be same or newer than jail. !!!
!!! Expect build failures. !!!

The jail was upgraded but the base system was not.
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2017-10-22 15:10:09 UTC 
Created attachment 187369 [details]
patch

Hi,

I'm experiencing the same problem on armv6.
The attached patch solves the issue for me.

unsigned long is 4 bytes on armv6 (dev_t is uint64_t) and it causes problem with bit shift operation used in t/gen-stat.c
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2017-10-22 15:11:19 UTC 
and major/minor requires an dev_t argument:
int major(dev_t dev);
int minor(dev_t dev);
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2017-10-23 15:31:40 UTC 
Created attachment 187396 [details]
patch

Fix more unsigned long / dev_t mismatch
Comment 7 Jim Pirzyk freebsd_committer freebsd_triage 2017-10-28 18:09:20 UTC 
So I guess there are 2 issues represented here by this PR.

1) The unsigned long <=> dev_t issue in File::Stats::Bits perl module
2) The Erroneous error message in the email.

The second one is what I am reporting here.  The build system either needs to be fixed in that the host environment needs to be upgraded to match the jail environment or the build error message needs to be removed.

!!! Jail is newer than host. (Jail: 1200041, Host: 1200040) !!!
!!! This is not supported. !!!
!!! Host kernel must be same or newer than jail. !!!
!!! Expect build failures. !!!

Mikael,

Please submit a bug fix to the upstream cpan module: http://search.cpan.org/~fedorov/File-Stat-Bits/

I will open up a new PR to incorporate your fix into the existing ports version.
Comment 8 Steve Wills freebsd_committer freebsd_triage 2019-01-07 16:59:58 UTC 
The build issue has disappeared and fixing that is not related to fixing the dev_t issue.
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-01-08 12:56:41 UTC 
A commit references this bug:

Author: swills
Date: Tue Jan  8 12:56:20 UTC 2019
New revision: 489677
URL: https://svnweb.freebsd.org/changeset/ports/489677

Log:
  sysutils/p5-File-Stat-Bits: Fix for dev_t size change

  Fixes armv6 and armv7 build

  PR:		223291
  PR:		221784
  Submitted by:	mikael.urankar@gmail.com
  Approved by:	maintainer timeout (pirzyk, >1 year)

Changes:
  head/sysutils/p5-File-Stat-Bits/Makefile
  head/sysutils/p5-File-Stat-Bits/files/
  head/sysutils/p5-File-Stat-Bits/files/patch-t_gen-stat.c