Bug 221792 - [exp-run] Add new qa check for ruby-based ports
Summary: [exp-run] Add new qa check for ruby-based ports
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-25 09:43 UTC by Torsten Zuehlsdorff
Modified: 2018-01-22 16:38 UTC (History)
3 users (show)

See Also:
tz: exp-run?


Attachments
Patch with new QA-check (2.11 KB, patch)
2017-08-25 09:43 UTC, Torsten Zuehlsdorff
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-08-25 09:43:51 UTC
Created attachment 185749 [details]
Patch with new QA-check

Aloha,

attached a patch for a new qa-check. It checks if all dependency declared in the Gemfile of an ruby-based port are satisfied. This can help greatly, because currently the only way to test for example www/gitlab or www/redmine (or any other ruby-port) is to install and execute it. Since all build-tests will be fine, even if the port does not work at all.

The check is executed for every port having USE_RUBY but with a portname not starting with rubygem-.

Diff-Review was here wit mat and lifanov:
https://reviews.freebsd.org/D11865

Greetings,
Torsten
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2017-08-26 06:41:08 UTC
The check looks wrong,  when bundle is not installed:


====> Running Q/A tests (stage-qa)
-p: not found
bundle: not found
Notice: Please install sysutils/rubygem-bundler for additional Gemfile-checks
Comment 2 Nikolai Lifanov freebsd_committer freebsd_triage 2017-08-28 12:57:18 UTC
I don't think "type" is supposed to have flags.

From man page for sh:
type [name ...]

Try instead doing this:
command -p -v bundle >/dev/null
Comment 3 Steve Wills freebsd_committer freebsd_triage 2017-12-24 19:50:09 UTC
What's the status of this? Just needs the check for bundle fixed and exp-run done? Anything else?
Comment 4 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-12-25 13:41:39 UTC
Yes, that is all what should be needed. Its still on my ToDo list, but i don't find any time for this before the second or third week in 2018. If you want to update it before feel free to go :)
Comment 5 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2018-01-22 15:08:47 UTC
@Steve
Please have a look at the review:
https://reviews.freebsd.org/D11865

I fixed all open issues and it should be ready to land. To you want to have a look at it as ruby@? ;)
Comment 6 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2018-01-22 16:38:24 UTC
I just committed the patch in r459673. Since mat pointed out, that there will be no benefit of having a QA-check i'm closing this PR.