Bug 222004 - audio/stk: Update to 4.6.0
Summary: audio/stk: Update to 4.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-02 19:03 UTC by Yuri Victorovich
Modified: 2017-09-10 10:25 UTC (History)
1 user (show)

See Also:


Attachments
patch (9.88 KB, patch)
2017-09-02 19:03 UTC, Yuri Victorovich
no flags Details | Diff
patch (9.88 KB, patch)
2017-09-09 17:29 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff
patch (8.27 KB, patch)
2017-09-10 03:28 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-09-02 19:03:30 UTC
Created attachment 186003 [details]
patch

QAs:
* poudriere 11.1 amd64
* portlint
* runs fine
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-09-09 17:00:15 UTC
It fails to build in a Poudriere 10.3/i386 jail:

===> Checking for items in pkg-plist which are not in STAGEDIR                                             
Error: Missing: %%DATADIR%%/rawwaves/._ahh.raw                                                                        
Error: Missing: %%DATADIR%%/rawwaves/._bassdrum.raw
Error: Missing: %%DATADIR%%/rawwaves/._britestk.raw
Error: Missing: %%DATADIR%%/rawwaves/._cowbell1.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._crashcym.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._dope.raw
Error: Missing: %%DATADIR%%/rawwaves/._eee.raw                                                                        
Error: Missing: %%DATADIR%%/rawwaves/._fwavblnk.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._halfwave.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._hihatcym.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._impuls10.raw
Error: Missing: %%DATADIR%%/rawwaves/._impuls20.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._impuls40.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._makefunc.c                                                                     
Error: Missing: %%DATADIR%%/rawwaves/._makemidi.c                                                                     
Error: Missing: %%DATADIR%%/rawwaves/._makewavs.c                                                                     
Error: Missing: %%DATADIR%%/rawwaves/._mand1.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mand10.raw                                                                     
Error: Missing: %%DATADIR%%/rawwaves/._mand11.raw                                                                     
Error: Missing: %%DATADIR%%/rawwaves/._mand12.raw
Error: Missing: %%DATADIR%%/rawwaves/._mand2.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mand3.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mand4.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mand5.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mand6.raw
Error: Missing: %%DATADIR%%/rawwaves/._mand7.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mand8.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mand9.raw                                                                      
Error: Missing: %%DATADIR%%/rawwaves/._mandpluk.raw
Error: Missing: %%DATADIR%%/rawwaves/._marmstk1.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._ooo.raw                                                                        
Error: Missing: %%DATADIR%%/rawwaves/._peksblnk.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._ppksblnk.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._ridecymb.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._silence.raw                                                                    
Error: Missing: %%DATADIR%%/rawwaves/._sine.c                                                                         
Error: Missing: %%DATADIR%%/rawwaves/._sineblnk.raw
Error: Missing: %%DATADIR%%/rawwaves/._sinewave.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._snardrum.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._snglpeak.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._tambourn.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._tomhidrm.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._tomlowdr.raw                                                                   
Error: Missing: %%DATADIR%%/rawwaves/._tommiddr.raw
Error: Missing: %%DATADIR%%/rawwaves/._twopeaks.raw  

._*.raw don't look like important files.  Do we need them?
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-09 17:29:55 UTC
Created attachment 186204 [details]
patch

Tobias,

I can't reproduce the failure. It succeeds for me in poudriere on 10.3-STABLE and 11.0-RELEASE-p7

Updating the patch just in case.

As for the files, they expect the whole folder. STK upstream forgot to install it via Makefile. I don't know if dotted files are actually needed or not. I assumed they are needed.


Regards,
Yuri
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-09 17:30:53 UTC
10.3-STABLE i386 and 11.0-RELEASE-p7 amd64
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2017-09-09 17:45:06 UTC
Please test it on 10.3-RELEASE/i386.  I can confirm that it builds fine on 10.3-STABLE/i386.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-09 18:48:59 UTC
(In reply to Tobias Kortkamp from comment #4)

Yes, on 10.3-RELEASE/i386 the dotted files aren't left. I asked stk upstream if they are needed. (They are going to get rid of the whole directory with .raw files in the next version.)
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-10 03:28:38 UTC
Created attachment 186217 [details]
patch

Removed files beginning with dots. Now it passes poudriere 10.3-RELEASE-p21 i386 and 11.0-RELEASE-p7 amd64.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-09-10 10:25:34 UTC
A commit references this bug:

Author: tobik
Date: Sun Sep 10 10:24:50 UTC 2017
New revision: 449530
URL: https://svnweb.freebsd.org/changeset/ports/449530

Log:
  audio/stk: Update to 4.6.0

  Changes:	https://ccrma.stanford.edu/software/stk/download.html#v4dot6dot0
  PR:             222004
  Submitted by:   Yuri Victorovich <yuri@rawbw.com> (maintainer)

Changes:
  head/audio/stk/Makefile
  head/audio/stk/distinfo
  head/audio/stk/files/patch-configure.ac
  head/audio/stk/files/patch-src_RtAudio.cpp
  head/audio/stk/pkg-plist