Bug 222021 - [PATCH] databases/sqlite3: changed a options logic
Summary: [PATCH] databases/sqlite3: changed a options logic
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-09-03 10:51 UTC by Pavel Volkov
Modified: 2019-06-02 10:05 UTC (History)
3 users (show)

See Also:


Attachments
patch (2.53 KB, patch)
2017-09-03 10:51 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
poudriere log (31.67 KB, text/plain)
2017-09-03 10:52 UTC, Pavel Volkov
no flags Details
patch (2.18 KB, patch)
2017-10-01 13:38 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
poudriere log (30.40 KB, text/plain)
2017-10-01 13:42 UTC, Pavel Volkov
no flags Details
patch (2.19 KB, patch)
2017-11-03 14:28 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
slightly updated patch (2.55 KB, patch)
2019-05-26 20:36 UTC, Steve Wills
no flags Details | Diff
change read/edit line logic (2.30 KB, patch)
2019-06-02 10:05 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2017-09-03 10:51:34 UTC
Created attachment 186024 [details]
patch

Changed a options for selecting the editing library.
Comment 1 Pavel Volkov 2017-09-03 10:52:02 UTC
Created attachment 186025 [details]
poudriere log
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-09-11 13:43:11 UTC
Sorry for the delay.
It took me some time to understand the changes which are not documented in this PR.

Here's the issues I found in this patch.

1.
You changed RL from GROUP to SINGLE (1 among N). 
Since you add NONERL to RL, it means RL is a RADIO (0 or 1 among N).

2.
You removed READLINES option and renamed READLINEP to READLINE.
But READLINE option will not bring in devel/readline on FreeBSD 10.x since /usr/lib/libreadline.so is available.
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-09-28 15:15:00 UTC
Feedback timeout. Back to pool.
Comment 4 Pavel Volkov 2017-10-01 08:51:13 UTC
(In reply to Po-Chuan Hsieh from comment #3)
Hello. Last times was a lot of work. I'm sorry for the delay. I'm working on the issues above.
Comment 5 Pavel Volkov 2017-10-01 13:38:16 UTC
Created attachment 186829 [details]
patch

Hello. You right. Let's do it differently, better. Please, look at new patch.

1. Yes, I do it.
2. No. USES= readline automatically chooses what is the use: 'port' or 'base' version library. For 10.x it's - base library.

It's as example:

FreeBSD fb10.lan 10.4-RC2 FreeBSD 10.4-RC2 #0 r323928: Fri Sep 22 17:08:03 UTC 2017     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

/usr/local/bin/sqlite3:
        libreadline.so.8 => /lib/libreadline.so.8 (0x800956000)
        libncurses.so.8 => /lib/libncurses.so.8 (0x800b99000)
        libthr.so.3 => /lib/libthr.so.3 (0x800de6000)
        libc.so.7 => /lib/libc.so.7 (0x80100a000)
Comment 6 Pavel Volkov 2017-10-01 13:42:34 UTC
Created attachment 186830 [details]
poudriere log

... and new poudriere log for 10.3.
Comment 7 Pavel Volkov 2017-11-03 14:28:59 UTC
Created attachment 187691 [details]
patch

New patch for new state, after upgrade the port to 3.21.
Comment 8 Steve Wills freebsd_committer 2019-05-26 20:36:41 UTC
Created attachment 204625 [details]
slightly updated patch

Are these changes still relevant? I had to make one slight change to it, to change OPTIONS_GROUP_RL to OPTIONS_RADIO_RL. Can you confirm this is correct?
Comment 9 Pavel Volkov 2019-06-02 10:05:15 UTC
Created attachment 204777 [details]
change read/edit line logic

Sorry for the long wait. I slightly changed this patch.
And yes. The libedit system library is not allowed to use in /usr/ports/Mk/Script/qa.sh. I do not know why.
Thank you.