Bug 222034 - lang/tcl86 fails to build with gcc
Summary: lang/tcl86 fails to build with gcc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-tcltk (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-03 19:44 UTC by Justin Hibbits
Modified: 2017-09-04 20:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tcltk)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer freebsd_triage 2017-09-03 19:44:42 UTC 
Since the update on August 19 to 8.6.7 lang/tcl86 no longer builds, giving the following error in the build log:

/wrkdirs/usr/ports/lang/tcl86/work/tcl8.6.7/unix/tclUnixSock.c: In function 'IPv6AddressNeedsNumericRendering':
/wrkdirs/usr/ports/lang/tcl86/work/tcl8.6.7/unix/tclUnixSock.c:716: error: #pragma GCC diagnostic not allowed inside functions
/wrkdirs/usr/ports/lang/tcl86/work/tcl8.6.7/unix/tclUnixSock.c:717: error: #pragma GCC diagnostic not allowed inside functions
/wrkdirs/usr/ports/lang/tcl86/work/tcl8.6.7/unix/tclUnixSock.c:719: error: #pragma GCC diagnostic not allowed inside functions
*** [tclUnixSock.o] Error code 1

This has been fixed upstream at http://core.tcl.tk/tcl/info/ba30aa3b1c7cc2c9 , but I haven't yet taken the time to isolate the specific patch component (the full patch from there fails to apply).
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-09-04 07:58:57 UTC 
A commit references this bug:

Author: gahr
Date: Mon Sep  4 07:58:31 UTC 2017
New revision: 449238
URL: https://svnweb.freebsd.org/changeset/ports/449238

Log:
  lang/tcl86: fix build with old GCC versions

  PR:		222034
  Submitted by:	jhibbits
  Obtained from:	http://core.tcl.tk/tcl/info/ba30aa3b1c7cc2c9

Changes:
  head/lang/tcl86/files/patch-unix-tclUnixSock.c
Comment 2 Pietro Cerutti freebsd_committer freebsd_triage 2017-09-04 08:00:15 UTC 
Thanks. Unfortunately I don't have a system running gcc-4.4 to test this. Feel free to reopen if the commit doesn't fix the problem for you.
Comment 3 Justin Hibbits freebsd_committer freebsd_triage 2017-09-04 20:36:24 UTC 
Just verified.  Thanks!