Bug 222073 - [MAINTAINER] devel/unibilium: Update to 1.2.1
Summary: [MAINTAINER] devel/unibilium: Update to 1.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-09-05 16:31 UTC by chuck
Modified: 2017-09-05 23:13 UTC (History)
1 user (show)

See Also:

Attachments
patch to update port to 1.2.1 (1.11 KB, patch)
2017-09-05 16:31 UTC, chuck 		no flags Details | Diff
patch to update port to 1.2.1 (1.39 KB, patch)
2017-09-05 17:34 UTC, chuck 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chuck 2017-09-05 16:31:49 UTC 
Created attachment 186083 [details]
patch to update port to 1.2.1

Updates to the latest upstream version
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-09-05 16:47:23 UTC 
% portlint -ac
WARN: Makefile: [15]: USE_* seen before USES.  According to the porters-handbook, USES must appear first.
0 fatal errors and 1 warning found.

Would you mind to silence the above warning?

Thanks
Comment 2 chuck 2017-09-05 17:09:23 UTC 
Weird. portlint doesn't report the same issue for me:

% portlint -ac
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 1 warning found.

I'm happy to move the USES line, but since my setup doesn't show the same error, I'm not sure how to check that the change addresses the issue you see.
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-09-05 17:21:38 UTC 
(In reply to chuck from comment #2)

Check to see if USE_* comes before USES was included in portlint version 2.17.10

% portlint -V
portlint version 2.17.12
Comment 4 chuck 2017-09-05 17:31:43 UTC 
% portlint -V
portlint version 2.17.8

I'll update the Makefile to move the USES line before any USE_*
Comment 5 chuck 2017-09-05 17:34:52 UTC 
Created attachment 186087 [details]
patch to update port to 1.2.1

move the USES before the USE_*
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-09-05 23:11:48 UTC 
A commit references this bug:

Author: cpm
Date: Tue Sep  5 23:11:01 UTC 2017
New revision: 449319
URL: https://svnweb.freebsd.org/changeset/ports/449319

Log:
  - Update to 1.2.1
  - Pet portlint, USE_* comes before USES

  Changes from 1.2.0 to 1.2.1

  - Deprecate direct access to unibi_var_t members
  - Better support for building Windows

  PR:		222073
  Submitted by:	chuck@tuffli.net (maintainer)

Changes:
  head/devel/unibilium/Makefile
  head/devel/unibilium/distinfo
  head/devel/unibilium/pkg-plist
Comment 7 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-09-05 23:13:01 UTC 
Committed!

Thanks