Bug 222327 - race condition in doc build
Summary: race condition in doc build
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wolfram Schneider
URL:
Keywords:
Depends on:
Blocks: 222322
  Show dependency tree / graph
 
Reported: 2017-09-14 12:02 UTC by Wolfram Schneider
Modified: 2017-09-19 09:57 UTC (History)
0 users

See Also:

Attachments
image build patch (3.04 KB, text/plain)
2017-09-14 12:03 UTC, Wolfram Schneider 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfram Schneider freebsd_committer freebsd_triage 2017-09-14 12:02:05 UTC 
There is a race condition in the documentation build. You cannot build the english and the german documentation at the same time.

Apparently, the share images (ps, eps, png) are not correctly build in an atomic way.

Solution: create temporary files during build, and only if it was complete and successfully created, the file will be moved to the final target name.
Comment 1 Wolfram Schneider freebsd_committer freebsd_triage 2017-09-14 12:03:22 UTC 
Created attachment 186377 [details]
image build patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-09-19 09:57:32 UTC 
A commit references this bug:

Author: wosch
Date: Tue Sep 19 09:57:15 UTC 2017
New revision: 50879
URL: https://svnweb.freebsd.org/changeset/doc/50879

Log:
  fix race conditions in doc image builds

  PR: 222327

Changes:
  head/share/mk/doc.images.mk