Bug 222396 - editors/xmlcopyeditor: Fails to compile with C++11
Summary: editors/xmlcopyeditor: Fails to compile with C++11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://sourceforge.net/p/xml-copy-ed...
Keywords:
Depends on:
Blocks: 221890
  Show dependency tree / graph
 
Reported: 2017-09-17 12:34 UTC by Roger Leigh
Modified: 2018-03-09 17:31 UTC (History)
2 users (show)

See Also:
jjuanino: maintainer-feedback+

Attachments
Initialise pointer portably (943 bytes, patch)
2017-09-17 12:34 UTC, Roger Leigh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Leigh 2017-09-17 12:34:14 UTC 
Created attachment 186462 [details]
Initialise pointer portably

Upstream ticket: https://sourceforge.net/p/xml-copy-editor/bugs/221/

Attached patch to allow building with C++11.
Comment 1 Jose G. Juanino 2017-09-19 20:31:50 UTC 
Hi,

excuse me my ignorance, but I am able to build the patch with C++11 standard, by mean of 

USE_CXXSTD=     c++11

in the Makefile.

Could you elaborate what port options lead to the compiler error? Regards
Comment 2 Jose G. Juanino 2017-09-19 20:57:15 UTC 
Hi again, after take a look to 221890 issue, I understand the problem. I can't test the whole of patches suggested in 221890, but the patchs looks fine to me and at least it works in the current ports tree (September 19th). Please commit.
Comment 3 Roger Leigh 2018-02-08 19:55:54 UTC 
Is any more information required before this can be committed?

Regarding the original question, this was answered in the linked upstream ticket.  It's correcting an illegal conversion from integer to pointer which current C++ conpilers error out on.
Comment 4 Tilman Keskinoz freebsd_committer freebsd_triage 2018-03-09 17:31:19 UTC 
committed, thanks
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-03-09 17:31:50 UTC 
A commit references this bug:

Author: arved
Date: Fri Mar  9 17:31:05 UTC 2018
New revision: 463980
URL: https://svnweb.freebsd.org/changeset/ports/463980

Log:
  Fix member initialization

  PR:		222396
  Submitted by:	Roger Leigh
  Approved by:	maintainer

Changes:
  head/editors/xmlcopyeditor/files/patch-src_myipc.cpp