Created attachment 186487 [details] poudriere build log When building packages on powerpc after updating my poudriere tree to the post-gcc6 switch, I see the following error: Source/WebCore/platform/gtk/GtkClickCounter.cpp: In member function 'int WebCore: :GtkClickCounter::clickCountForGdkButtonEvent(GtkWidget*, GdkEventButton*)': Source/WebCore/platform/gtk/GtkClickCounter.cpp:88:59: error: call of overloaded 'abs(gdouble)' is ambiguous || ((abs(buttonEvent->x - m_previousClickPoint.x()) < doubleClickDistanc e) ^ In file included from /usr/local/lib/gcc6/include/c++/cstdlib:75:0, from /usr/local/lib/gcc6/include/c++/stdlib.h:36, from ./Source/WTF/wtf/FastMalloc.h:25, from ./Source/JavaScriptCore/config.h:60, from Source/WebCore/platform/gtk/GtkClickCounter.cpp:19: /usr/include/stdlib.h:85:6: note: candidate: int abs(int) int abs(int) __pure2; ^~~ In file included from /usr/local/lib/gcc6/include/c++/stdlib.h:36:0, from ./Source/WTF/wtf/FastMalloc.h:25, from ./Source/JavaScriptCore/config.h:60, from Source/WebCore/platform/gtk/GtkClickCounter.cpp:19: /usr/local/lib/gcc6/include/c++/cstdlib:180:3: note: candidate: long long int std::abs(long long int) abs(long long __x) { return __builtin_llabs (__x); } ^~~ /usr/local/lib/gcc6/include/c++/cstdlib:172:3: note: candidate: long int std::abs(long int) abs(long __i) { return __builtin_labs(__i); } ^~~ The full log is attached.
--- Source/WebCore/platform/gtk/GtkClickCounter.cpp.orig 2018-02-07 02:12:45 UTC +++ Source/WebCore/platform/gtk/GtkClickCounter.cpp @@ -85,8 +85,8 @@ int GtkClickCounter::clickCountForGdkBut guint32 eventTime = getEventTime(event); if ((event->type == GDK_2BUTTON_PRESS || event->type == GDK_3BUTTON_PRESS) - || ((abs(buttonEvent->x - m_previousClickPoint.x()) < doubleClickDistance) - && (abs(buttonEvent->y - m_previousClickPoint.y()) < doubleClickDistance) + || ((fabs(buttonEvent->x - m_previousClickPoint.x()) < doubleClickDistance) + && (fabs(buttonEvent->y - m_previousClickPoint.y()) < doubleClickDistance) && (eventTime - m_previousClickTime < static_cast<guint>(doubleClickTime)) && (buttonEvent->button == m_previousClickButton))) m_currentClickCount++;
It needs a patch to Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp as well for the same problem. https://aur.archlinux.org/cgit/aur.git/tree/webkitgtk-2.4.9-abs.patch?h=webkitgtk has a complete patch to both files that fixes it.
Created attachment 190401 [details] svn-diff-webkit-gtk2 Ok, let's do it. (But I have not tested yet).
Created attachment 190403 [details] svn-diff-webkit-gtk2_v2 The pathes to the files were wrong.
The same diff should be applied to www/webkit-gtk3 as well. I'm currently test building on one of my machines, but it's slow so will take quite a while to build.
Created attachment 190407 [details] svn-diff-webkit-gtk3 Patches applies, but not further tested.
I guess you test on 11.X. So I tested with poudriere on 10.4-amd64, for both successful.
(In reply to w.schwarzenfeld from comment #7) I test on powerpc* -CURRENT. If you tested building with gcc6, even on amd64, that's sufficient for me. My current build run is on powerpcspe, so takes a *very* long time to build.
Builds fine for me on powerpcspe, so go ahead and commit.
Created attachment 194212 [details] Corrected patch currently under test
Created attachment 194213 [details] Corrected patch currently under test
Comment on attachment 194212 [details] Corrected patch currently under test corrected patch for webkit-gtk2.
Comment on attachment 194213 [details] Corrected patch currently under test corrected patch for webkit-gtk3.
(In reply to Mark Linimon from comment #13) Even with this patch for webkit-gtk3, I still get: In file included from ./Source/JavaScriptCore/jit/GPRInfo.h:29:0, from ./Source/JavaScriptCore/runtime/VM.h:34, from ./Source/JavaScriptCore/heap/CopiedSpaceInlines.h:33, from ./Source/JavaScriptCore/runtime/ButterflyInlines.h:31, from ./Source/JavaScriptCore/runtime/JSArray.h:25, from ./Source/JavaScriptCore/bytecode/ArrayProfile.h:30, from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28: ./Source/JavaScriptCore/assembler/MacroAssembler.h:66:2: error: #error "The MacroAssembler is not supported on this platform." #error "The MacroAssembler is not supported on this platform."
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/assembler/MacroAssembler.h
www/webkit-gtk2||2019-03-24|Has expired: webkit-gtk* last release in 2016 and security issues www/webkit-gtk3||2019-03-24|Has expired: webkit-gtk* last release in 2016 and security issues Close here, overcome by events.