Bug 222472 - java/intellij-ultimate: Update to 2017.2.5
Summary: java/intellij-ultimate: Update to 2017.2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-09-20 14:39 UTC by Ivan
Modified: 2017-12-17 22:12 UTC (History)
4 users (show)

See Also:
andoriyu: maintainer-feedback+


Attachments
update (89.79 KB, application/zip)
2017-10-08 16:04 UTC, Ivan
no flags Details
Patch to update it to 2017.2.5 (153 bytes, patch)
2017-11-04 22:30 UTC, Andrey Cherkashin
andoriyu: maintainer-approval+
Details | Diff
Patch to update it to 2017.2.5 (153 bytes, patch)
2017-11-06 01:35 UTC, Andrey Cherkashin
andoriyu: maintainer-approval+
Details | Diff
Patch to update it to 2017.2.5 (153 bytes, patch)
2017-11-13 19:43 UTC, Andrey Cherkashin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2017-09-20 14:39:23 UTC
Intellij Ultimate version is rather old. Can it be updated to latest ?
Comment 1 Andrey Cherkashin 2017-09-20 18:22:58 UTC
(In reply to Ivan from comment #0)
Yes, I will take care of it tomorrow.
Comment 2 Ivan 2017-10-06 07:36:50 UTC
Are there any problems/can I help ? Maybe we can take necessary bits from intellij port ? 

The problem with current version built against current port tree that all default templates has disappeared, so I can't track current port tree anymore.

intellij port has all templates in place, so maybe bump of intellij-ultimate to latest version will help.

Thanks!
Comment 3 Ivan 2017-10-08 16:04:07 UTC
Created attachment 187006 [details]
update
Comment 4 Ivan 2017-10-08 16:04:57 UTC
As I expected, version upgrade helped. I archived the patch as it's too big.
Comment 5 Andrey Cherkashin 2017-10-08 20:50:22 UTC
LGTM. Sorry didn't get to it myself.
Comment 6 Andrey Cherkashin 2017-11-04 22:30:57 UTC
Created attachment 187742 [details]
Patch to update it to 2017.2.5
Comment 7 Andrey Cherkashin 2017-11-04 22:31:58 UTC
Comment on attachment 187006 [details]
update

outdated
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2017-11-05 02:04:09 UTC
Please confirm the change passes QA (poudriere and portlint in particular)
Comment 9 Andrey Cherkashin 2017-11-06 01:35:20 UTC
Created attachment 187773 [details]
Patch to update it to 2017.2.5

portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: save for ports directly related to the Java language, porters are encouraged not to use ``java'' as the main category for a port
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 3 warnings found.
Comment 10 Richard Gallamore freebsd_committer freebsd_triage 2017-11-12 02:02:29 UTC
When testing on 103i386, the following error is generated.
/usr/bin/strip: /wrkdirs/usr/ports/java/intellij-ultimate/work/stage/usr/local/intellij/plugins/tfsIntegration/lib/native/freebsd/x86_64/libnative_synchronization.so: File format not recognized
*** Error code 1

full log here: https://poudriere.ultimasbox.com/data/103i386-test/2017-11-11_16h48m10s/logs/errors/intellij-ultimate-2017.2.5.log
Comment 11 Ivan 2017-11-12 09:41:48 UTC
(In reply to Richard Gallamore from comment #10)

Suggestions:
1. Add ARCH amd64
2. Remove 64-bit binaries for i386
3. Don't strip stuff
Comment 12 Andrey Cherkashin 2017-11-13 19:43:51 UTC
Created attachment 187974 [details]
Patch to update it to 2017.2.5

Removed stripping of native libraries like it was before.
Comment 13 vali gholami 2017-11-26 20:53:30 UTC
MARKED AS SPAM
Comment 14 Boris Samorodov freebsd_committer freebsd_triage 2017-12-14 12:06:25 UTC
Take.
Comment 15 commit-hook freebsd_committer freebsd_triage 2017-12-15 11:42:26 UTC
A commit references this bug:

Author: bsam
Date: Fri Dec 15 11:42:12 UTC 2017
New revision: 456392
URL: https://svnweb.freebsd.org/changeset/ports/456392

Log:
  java/intellij-ultimate: Update to 2017.2.5.

  PR:		222472
  Submitted by:	Ivan <bsd@abinet.ru>
  Patch by:	Andrey Cherkashin <andoriyu@gmail.com> (maintainer)

Changes:
  head/java/intellij-ultimate/Makefile
  head/java/intellij-ultimate/distinfo
  head/java/intellij-ultimate/pkg-plist
Comment 16 Boris Samorodov freebsd_committer freebsd_triage 2017-12-15 11:46:09 UTC
Committed, thanks!

As a side note:
1. There is a newer version available.
2. One may add my email to the CC list while open a PR about Jetbrans products.
Comment 17 Andrey Cherkashin 2017-12-15 17:44:23 UTC
(In reply to Boris Samorodov from comment #16)
Got it. Thank you!
Comment 18 Andrey Cherkashin 2017-12-17 00:34:07 UTC
(In reply to Boris Samorodov from comment #16)
Is there an easy way to generate pkg-plist for jetbrains products?
Comment 19 Boris Samorodov freebsd_committer freebsd_triage 2017-12-17 22:12:51 UTC
TLDR; For me "make makeplist" does the hard part.

The longer version.
For a new port version I use "testport" poudriere command with interactive shell ("-i" option). When a shell prompt is invoked I use "make -C /usr/ports/whatever/port makeplist > /tmp/pkg-plist" command to create a raw pkg-plist version. Then (before closing the jail, i.e. before exitting from a shell) get this pkg-plist at the host (ex. $POUDRIERE_HOME/data/.m/103-amd64-testing/ref/tmp/pkg-plist). Fix it (sed command or smth else) and make it use.

That's it. ;-)

HTH & WBR, bsam