Bug 222781 - usr.bin/hexdump/hexdump_test:{s,v}_flag tests no longer failing as expected after r323990
Summary: usr.bin/hexdump/hexdump_test:{s,v}_flag tests no longer failing as expected a...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: Kyle Evans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-04 16:50 UTC by Enji Cooper
Modified: 2018-01-27 06:32 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer 2017-10-04 16:50:42 UTC
The s_flag and v_flag tests have been flapping on Jenkins for some time now. They should be skipped or removed if the root-cause can't be found quickly since flapping tests reduces confidence in the tests being useful and generates unnecessary noise.
Comment 1 commit-hook freebsd_committer 2017-10-04 18:11:35 UTC
A commit references this bug:

Author: kevans
Date: Wed Oct  4 18:11:01 UTC 2017
New revision: 324286
URL: https://svnweb.freebsd.org/changeset/base/324286

Log:
  hexdump: Remove expected test failures for now succeeding tests

  r323990 fixed the -s flag breakage reported by PR 219173. Mark the
  corresponding hexdump tests accordingly, since they should now both succeed.

  PR:		222781
  Reported by:	ngie
  Reviewed by:	emaste, ngie
  Approved by:	emaste (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12590

Changes:
  head/usr.bin/hexdump/tests/hexdump_test.sh
Comment 2 commit-hook freebsd_committer 2018-01-27 06:31:52 UTC
A commit references this bug:

Author: kevans
Date: Sat Jan 27 06:31:14 UTC 2018
New revision: 328463
URL: https://svnweb.freebsd.org/changeset/base/328463

Log:
  MFC r320930,r324286: Add tests for hexdump(1)

  MFC r320930:
  Add some basic tests for hexdump(1)'s various output flags. Formatting
  tests are omitted for this initial run as there are still some bugs to work
  out there.

  This covers -s flag testing on devices and non-devices that would have
  caught breakage found in PR 219173 as well as other subtle breakage caused
  locally.

  MFC r324286: hexdump: Remove expected test failures for now succeeding tests

  r323990 fixed the -s flag breakage reported by PR 219173. Mark the
  corresponding hexdump tests accordingly, since they should now both succeed.

  PR:		222781

Changes:
_U  stable/11/
  stable/11/etc/mtree/BSD.tests.dist
  stable/11/usr.bin/hexdump/Makefile
  stable/11/usr.bin/hexdump/tests/
  stable/11/usr.bin/hexdump/tests/hexdump_test.sh