Bug 222864 - databases/postgresql10-server: Add pg_resetwal and pg_waldump (fixing pg_upgrade)
Summary: databases/postgresql10-server: Add pg_resetwal and pg_waldump (fixing pg_upgr...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: pgsql
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-10-08 15:48 UTC by VoidChicken
Modified: 2017-10-09 21:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pgsql)
VoidChicken: merge-quarterly?

Attachments
Alter INSTALL_DIRS in Makefile (792 bytes, patch)
2017-10-08 15:48 UTC, VoidChicken 		VoidChicken: maintainer-approval? (pgsql)
 Details | Diff
Add pg_resetwal and pg_waldump to pkg-plist-server (407 bytes, patch)
2017-10-08 15:49 UTC, VoidChicken 		VoidChicken: maintainer-approval? (pgsql)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description VoidChicken 2017-10-08 15:48:23 UTC 
Created attachment 187004 [details]
Alter INSTALL_DIRS in Makefile

Starting with Postgresql 10, the pg_resetxlog utility has been renamed to pg_resetwal. The postgresql10-server makefile attempts to build the old name, and neither appears in the plist. The result is that pg_resetwal is never installed. In addition, pg_upgrade breaks when pg_resetwal is not found.

The attached patches allow pg_resetwal to be properly built and installed.

While here, similarly re-add pg_waldump (formerly known as pg_xlogdump).
Comment 1 VoidChicken 2017-10-08 15:49:08 UTC 
Created attachment 187005 [details]
Add pg_resetwal and pg_waldump to pkg-plist-server
Comment 2 VoidChicken 2017-10-08 16:03:22 UTC 
Builds in poudriere on 11.1 amd64.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-10-08 16:41:18 UTC 
A commit references this bug:

Author: girgen
Date: Sun Oct  8 16:39:59 UTC 2017
New revision: 451550
URL: https://svnweb.freebsd.org/changeset/ports/451550

Log:
  PostgreSQL has renamed wal as xlog to avoid human errors.

  This has caused some binaries to change names. Fix the port so they will be
  installed again with their new names.

  Noticed by:	VoidChicken@gmail.com
  PR:		222864

Changes:
  head/databases/postgresql10-server/Makefile
  head/databases/postgresql10-server/pkg-plist-server
Comment 4 Palle Girgensohn freebsd_committer freebsd_triage 2017-10-08 16:44:55 UTC 
Committed with NLS additions. Thanks!
Comment 5 VK freebsd_triage 2017-10-08 16:53:01 UTC 
Please consider this bugfix for the Quarterly. Thanks.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-10-09 21:37:11 UTC 
A commit references this bug:

Author: girgen
Date: Mon Oct  9 21:36:45 UTC 2017
New revision: 451645
URL: https://svnweb.freebsd.org/changeset/ports/451645

Log:
  MFH: r451310 r451550

  PostgreSQL 10 Released!

  Some highlights:

  Logical Replication - A publish/subscribe framework for distributing data
  Declarative Table Partitioning - Convenience in dividing your data
  Improved Query Parallelism - Quickly conquer your analysis
  Quorum Commit for Synchronous Replication - Distribute data with confidence
  SCRAM-SHA-256 authentication - Secure your data access

  URL:	https://www.postgresql.org/about/news/1786/
  Noticed by:	VoidChicken@gmail.com
  PR:		222864
  Approved by:	ports-secteam

Changes:
_U  branches/2017Q4/
  branches/2017Q4/databases/postgresql10-server/Makefile
  branches/2017Q4/databases/postgresql10-server/distinfo
  branches/2017Q4/databases/postgresql10-server/pkg-plist-server