Created attachment 187204 [details] mail/opendkim-2.10.3_8.diff The comments in the milter-opendkim rc script state that milteropendkim_socket is one of the parameters that can instead be set in opendkim.conf(5) config file. However, when running the rc script to start or restart the daemon, the usage for chmod is printed as if it was invoked with incorrect parameters. I tracked this down to milteropendkim_socket being unset and [ -S ... ] returning 0 in sh if its argument is blank and unquoted in the dkim_start_postcmd function. I have provided a patch which avoids this by first checking if milteropendkim_socket is not blank. portlint: OK (0 fatal errors and 16 warnings found.) testport: OK (poudriere: 103i386, 103amd64, 111i386, 111amd64)
Created attachment 187746 [details] mail/opendkim-2.10.3_8.diff Updated patch after whitespace changes from ports r453284.
*** Bug 221878 has been marked as a duplicate of this bug. ***
Hi, I'm using inet:port@address as "Socket" in opendkim.conf and was also suffering from this problem. Your patch prevents the chmod from ever happening on my system, so the rc script does not throw any errors anymore. TnX Regards, Ruben
Maintainer feedback, please!
I just noticed the same and started a pr myself... The attached tries to cover a few additional cases where a empty milteropendkim_socket is not handled.
Created attachment 197226 [details] mail/opendkim-2.10.3_9 rc script
It looks like this is fixed by the fix for bug #208056 (ports r481909).