Bug 223154 - [PATCH] www/phpvirtualbox: fix attaching new drive
Summary: [PATCH] www/phpvirtualbox: fix attaching new drive
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Virtualbox Team (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-10-22 03:21 UTC by Ivan Rozhuk
Modified: 2018-02-06 22:25 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (vbox)


Attachments
err message (90.71 KB, text/plain)
2017-10-22 03:21 UTC, Ivan Rozhuk
no flags Details
patch (41.38 KB, patch)
2017-10-22 03:24 UTC, Ivan Rozhuk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2017-10-22 03:21:08 UTC
Created attachment 187356 [details]
err message

Andrew: "I just discovered a problem trying to attach a new HardDisk to an existing VM. The operation fails with the attached error messages and (this is the worst thing) the HardDisk is considered by VBoxSVC as attached to the VM even if the operation failed. This problem prevents to delete or reattach the HDD until the process VBoxSVC exits (stopping all VMs running on the host), thus this is quite a devastating issue in a production scenario! :S"
Comment 1 Ivan Rozhuk 2017-10-22 03:24:40 UTC
Created attachment 187357 [details]
patch

Works for me, more qa required.
Comment 2 Andrew 2017-10-22 14:35:31 UTC
Thank you very much, Ivan!

I just tried your patch and it solves the problem for me without braking anything else, as far as I was able to test so far (working on VirtualBox 5.1.26 headless server).
In the next days I'll roll it out in some production environments, and I'll quickly post any issue eventually.

If you do not read anything from me within the end of the next week, I guess it will be OK to commit the patch.

Best regards.

Andrew
Comment 3 Andrew 2018-01-16 11:27:46 UTC
Only to confirm that the patch works even against the latest VirtualBox release (5.2.4), thus I guess this PR can be closed. It would be nice to have the patch committed to the Ports repository. Thanks!
Comment 4 Ivan Rozhuk 2018-02-06 22:25:15 UTC
Fixed in: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225714