Bug 223573 - vnic: multicast not implemented
Summary: vnic: multicast not implemented
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: arm64 Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords: ThunderX
Depends on:
Blocks: 203349
  Show dependency treegraph
 
Reported: 2017-11-09 20:31 UTC by Ed Maste
Modified: 2018-05-28 19:49 UTC (History)
1 user (show)

See Also:
emaste: mfc-stable11+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2017-11-09 20:31:46 UTC
See https://svnweb.freebsd.org/base/head/sys/dev/vnic/nicvf_main.c?view=markup#l498 and l516. nicvf_set_multicast is not implemented.
Comment 1 Ed Maste freebsd_committer 2017-11-10 01:42:18 UTC
Note that the Linux driver which was used for porting (Cavium provided a BSD licensed version) also uses promiscuous mode: https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/cavium/thunder/thunder_bgx.c#L889
Comment 2 commit-hook freebsd_committer 2017-11-14 16:31:56 UTC
A commit references this bug:

Author: emaste
Date: Tue Nov 14 16:31:12 UTC 2017
New revision: 325811
URL: https://svnweb.freebsd.org/changeset/base/325811

Log:
  vnic: report that the driver supports multicast

  The driver is currently hardcoded to force promiscuous mode, so all of
  the MAC filtering code is presently unused and multicast should "just
  work."  Report to the higher layers that multicast is supported.

  PR:		223573
  Reported by:	bz
  Sponsored by:	The FreeBSD Foundation, Packet.net (hardware)

Changes:
  head/sys/dev/vnic/nicvf_main.c
Comment 3 commit-hook freebsd_committer 2017-11-21 13:59:49 UTC
A commit references this bug:

Author: emaste
Date: Tue Nov 21 13:59:40 UTC 2017
New revision: 326059
URL: https://svnweb.freebsd.org/changeset/base/326059

Log:
  MFC r325811: vnic: report that the driver supports multicast

  The driver is currently hardcoded to force promiscuous mode, so all of
  the MAC filtering code is presently unused and multicast should "just
  work."  Report to the higher layers that multicast is supported.

  PR:		223573
  Reported by:	bz
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/11/
  stable/11/sys/dev/vnic/nicvf_main.c
Comment 4 Ed Maste freebsd_committer 2017-11-21 14:23:56 UTC
Leave open: we report that the interface supports multicast, but do not actually configure multicast rx filters in the driver yet.
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2018-05-28 19:49:21 UTC
batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.