Bug 223620 - graphics/sane-backends: sane-desc.c footer timestamp prevents build from being reproducible
Summary: graphics/sane-backends: sane-desc.c footer timestamp prevents build from bein...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-12 05:48 UTC by delete2
Modified: 2018-03-12 09:45 UTC (History)
1 user (show)

See Also:

Attachments
Removes timestamp from footer to support reproduciblity (580 bytes, text/x-csrc)
2017-11-12 05:48 UTC, delete2 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description delete2 2017-11-12 05:48:10 UTC 
Created attachment 187930 [details]
Removes timestamp from footer to support reproduciblity

Hello, I am posting this report to further the agenda of reproducible builds (wiki.freebsd.org/ReproducibleBuilds)

In this particular port, a timestamp is documented in sane-desc.c, in the 'html_print_footer' function, and this causes the port to remain unreproducible each time it is built.

Removal of the timestamp mentions in the footer function makes this port reproducible.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-12 09:45:10 UTC 
I'm not really sure how to check if it's really reproducible now, but the
patch seems harmless, so committed. Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-03-12 09:45:35 UTC 
A commit references this bug:

Author: tobik
Date: Mon Mar 12 09:44:34 UTC 2018
New revision: 464242
URL: https://svnweb.freebsd.org/changeset/ports/464242

Log:
  graphics/sane-backends: Make reproducible

  - Don't add a timestamp at build time to the docs
  - While here add missing USES=jpeg

  PR:		223620
  Submitted by:	Michael Kotlyar <mdk369@nyu.edu>

Changes:
  head/graphics/sane-backends/Makefile
  head/graphics/sane-backends/files/patch-tools_sane-desc.c