Bug 223674 - new port: sysutils/fd: fd is a simple, fast and user-friendly alternative to find.
Summary: new port: sysutils/fd: fd is a simple, fast and user-friendly alternative to ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-15 02:54 UTC by Andrey Cherkashin
Modified: 2017-11-15 18:35 UTC (History)
2 users (show)

See Also:

Attachments
new port patch (12.02 KB, patch)
2017-11-15 02:54 UTC, Andrey Cherkashin 		no flags Details | Diff
new port (fix portlint errors) (12.02 KB, patch)
2017-11-15 02:57 UTC, Andrey Cherkashin 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Cherkashin 2017-11-15 02:54:29 UTC 
Created attachment 188006 [details]
new port patch
Comment 1 Andrey Cherkashin 2017-11-15 02:57:28 UTC 
Created attachment 188007 [details]
new port (fix portlint errors)

$ portlint -ac
looks fine.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-15 10:17:40 UTC 
Thank you for your submission!

Are both of these really needed:
>                bitflags-0.7.0 \
>                bitflags-0.9.1 \
?

Yuri
Comment 3 Andrey Cherkashin 2017-11-15 10:23:13 UTC 
(In reply to Yuri Victorovich from comment #2)
According to Cargo.lock — yes. Pretty common on rust projects to have multiple version of the same crate.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-15 10:24:40 UTC 
(In reply to Andrey Cherkashin from comment #3)

Ok, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-11-15 12:42:39 UTC 
A commit references this bug:

Author: tobik
Date: Wed Nov 15 12:41:38 UTC 2017
New revision: 454236
URL: https://svnweb.freebsd.org/changeset/ports/454236

Log:
  New port: sysutils/fd

  fd is a simple, fast and user-friendly alternative to find.
  While it does not seek to mirror all of find's powerful functionality,
  it provides sensible (opinionated) defaults for 80% of the use cases.

  WWW: https://github.com/sharkdp/fd

  PR:		223674
  Submitted by:	Andrey Cherkashin <andoriyu@gmail.com>

Changes:
  head/sysutils/Makefile
  head/sysutils/fd/
  head/sysutils/fd/Makefile
  head/sysutils/fd/distinfo
  head/sysutils/fd/pkg-descr
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2017-11-15 12:43:43 UTC 
Committed. Thanks!

A couple of changes were necessary:

- Patching build.rs like what textproc/ripgrep does is not needed as
  fd already provides a nice alternative for us via
  SHELL_COMPLETIONS_DIR.  In ripgrep we need to patch build.rs because
  OUT_DIR is generated by Cargo itself with non-deterministic directory
  names and then passed to the build and we cannot override it in the
  port.

- GH_TAGNAME basically defaults to
  ${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX}, so setting it
  directly is only necessary in very specific cases.

- The port conflicts with shells/fd as both install /usr/local/bin/fd
  and unfortunately both have the same package name.  In Cargo.toml the
  project is named fd-find, so a -find package name suffix seems like an
  acceptable fix.
Comment 7 Andrey Cherkashin 2017-11-15 18:35:07 UTC 
(In reply to Tobias Kortkamp from comment #6)
Whools, totally forgot about DISTVERSIONSUFFIX.