Bug 223967 - ftp/curl: Update to 7.58.0 add brotli libssh support
Summary: ftp/curl: Update to 7.58.0 add brotli libssh support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords: needs-qa, patch
Depends on: 223966
Blocks:
  Show dependency tree / graph
 
Reported: 2017-11-29 14:00 UTC by Bernard Spil
Modified: 2018-01-30 15:41 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
svn diff for ftp/curl (6.92 KB, patch)
2017-11-29 14:00 UTC, Bernard Spil 		no flags Details | Diff
svn diff for ftp/curl (6.07 KB, patch)
2017-12-02 12:32 UTC, Bernard Spil 		no flags Details | Diff
svn diff for ftp/curl (7.37 KB, patch)
2018-01-24 08:26 UTC, Bernard Spil 		brnrd: maintainer-approval? (sunpoet)
 Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2017-11-29 14:00:07 UTC 
Created attachment 188393 [details]
svn diff for ftp/curl

```
ftp/curl: Security update to 7.57.0

 - Adds brotli compression

PR: 
Security: 
MFH: 2017Q4
```
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2017-11-29 14:01:15 UTC 
Brotli option requires updated libbrotli, see bug #223966
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2017-11-29 14:28:38 UTC 
```
ftp/curl: Security update to 7.57.0

 - Adds brotli compression

PR: 223967
Security: 301a01b7-d50e-11e7-ac58-b499baebfeaf
MFH: 2017Q4
```
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2017-12-02 12:32:57 UTC 
Created attachment 188470 [details]
svn diff for ftp/curl

```
ftp/curl: Add brotli compression support

 - Upstream added brotli support
 - Fix build with nss
 - Add protocol category and options
 - CA-bundle works for Polar-/OpenSSL/GnuTLS
 - CONFIGURE_ON to _WITH where possible
 - Fix TLS-SRP options check

PR: 223967
```

Tested CA-bundle support with all backends, only NSS seems to use a different mechanism (although I couldn't find the actual CA store).
TLS-SRP with GnuTLS is a valid option when LibreSSL is used, collapse 2 checks into one.
NSS was broken at compile time, had to add CFLAGS LDFLAGS to make it work.
As many options were added, I put them in a for loop to reduce Makefile length.
Comment 4 Bernard Spil freebsd_committer freebsd_triage 2017-12-12 08:16:46 UTC 
The dependency has been solved/committed.

Can we progress with this update?
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2018-01-24 08:26:56 UTC 
Created attachment 190025 [details]
svn diff for ftp/curl

Update to 7.58.0
add libssh support
switch some options to use pkgconfig instead (libssh doesn't build --with-libssh=/usr/local but does with pkgconfig).
Comment 6 FStl 2018-01-28 07:23:06 UTC 
Please upgrade curl in the quarterly branch too.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-01-30 15:39:37 UTC 
A commit references this bug:

Author: sunpoet
Date: Tue Jan 30 15:39:00 UTC 2018
New revision: 460400
URL: https://svnweb.freebsd.org/changeset/ports/460400

Log:
  Add more options

  - Add protocol group
  - Convert already-enabled protocols to IMAP, POP3, RTSP and SMTP options
  - Add DICT, FTP, GOPHER, HTTP, TELNET and TFP options
  - Update CA_BUNDLE_DESC
  - Use CA_BUNDLE_CONFIGURE_WITH and OPENSSL_CONFIGURE_WITH
  - Merge TLS_SRP check

  PR:		223967 (based on)
  Submitted by:	brnrd

Changes:
  head/ftp/curl/Makefile
Comment 8 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-01-30 15:41:56 UTC 
Committed. Thanks!