Bug 223980 - shebangfix should patch 'python3' into full python executable path
Summary: shebangfix should patch 'python3' into full python executable path
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-30 00:16 UTC by Yuri Victorovich
Modified: 2017-12-01 14:29 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-11-30 00:16:36 UTC 
Currently it doesn't patch this:
> #!/usr/bin/env python3
Since there can be many flavors of the same app installed for different python versions, this should be patched for specific python version to be used.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2017-11-30 16:35:55 UTC 
Can you provide an example?
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-30 16:55:21 UTC 
(In reply to Mathieu Arnold from comment #1)

www/py-ddgr

I had to patch python3 -> python in order for shebangfix to kick in.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-30 17:08:36 UTC 
Since all dependencies are installed according to a python version, it's only reasonable that the executable uses this specific version too. Otherwise, it's generally broken.
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2017-12-01 14:29:05 UTC 
There is no other port that need this, so I'm going to say no.

This is why there is the possibility of setting <lang>_OLD_CMD in the port's Makefile, to catch the cases where it does not have the right magic string.