Bug 224138 - ports-mgmt/portshaker doesn't process argument splitting (':') on copy_to ('+')
Summary: ports-mgmt/portshaker doesn't process argument splitting (':') on copy_to ('+')
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Romain Tartière
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-06 02:17 UTC by Duane
Modified: 2018-01-16 09:19 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Duane 2017-12-06 02:17:22 UTC 
In the portshaker shell script around line 177 it converts ':' to ' ' with the following command:

  _source=`echo ${_source} | sed -e 's|:| |g'`

Unfortunately this is too late in the case that we are trying to do a `copy_to` for a partial/incomplete ports tree.  This case (with the trailing '+' character) is short-circuited around line 166.
Comment 1 Romain Tartière freebsd_committer freebsd_triage 2018-01-02 11:02:55 UTC 
Hello!  Sorry, I worked on this some times ago and forgot to follow-up.

I proposed a fix here:
https://github.com/smortex/portshaker/pull/20

The relevant change is:
https://github.com/smortex/portshaker/pull/20/commits/7217a5670e57b13bf314dcaad789b1508b8318e6

Can you please tell me if it fixes your problem as expected so that I can release a new version with this fix?

Thanks!
Comment 2 Duane 2018-01-14 22:27:21 UTC 
(In reply to Romain Tartière from comment #1)

Yes, your proposed change fixes the problem.

Thanks.
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2018-01-16 09:10:48 UTC 
Cool, thanks!

Will commit an update soon!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-01-16 09:18:07 UTC 
A commit references this bug:

Author: romain
Date: Tue Jan 16 09:17:05 UTC 2018
New revision: 459162
URL: https://svnweb.freebsd.org/changeset/ports/459162

Log:
  Update to 1.0.15

  This release address a few minor issues, including [2].

  While here:
  - Simplify Makefile depend logic [1];
  - Add license.

  PR:		205830 [1], 224138 [2]
  Submitted by:	simon.wright@gmx.net [1], parakleta@darkreality.org [2]

Changes:
  head/ports-mgmt/portshaker/Makefile
  head/ports-mgmt/portshaker/distinfo
Comment 5 Romain Tartière freebsd_committer freebsd_triage 2018-01-16 09:19:09 UTC 
Thanks!