Bug 224279 - audio/volumeicon: Update to 0.5.1
Summary: audio/volumeicon: Update to 0.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lars Engels
URL: http://nullwise.com/volumeicon.html
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-12-12 15:43 UTC by Dmitri Goutnik
Modified: 2017-12-13 10:15 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lme)


Attachments
patch file (1.96 KB, patch)
2017-12-12 15:43 UTC, Dmitri Goutnik
no flags Details | Diff
patch file (6.41 KB, patch)
2017-12-12 18:59 UTC, Dmitri Goutnik
dmgk: maintainer-approval? (lme)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2017-12-12 15:43:26 UTC
Created attachment 188756 [details]
patch file

* Switch master site to Github [1]
* Update to 0.5.1
* Pet portlint

Changes [1]:
  Added german and polish translations.
  Added commandline switch to turn off notifications.
  Added option to choose soundcard from either gui or commandline.
  Added option to use GTK+ popup window for volume change notifications.
  Changed preferences GUI so it fits on smaller screens.
  Added flag --version, -v to print version information.

QA:
  portlint -AC: OK
  poudriere testport: OK (11a, 10i)

[1] http://nullwise.com/volumeicon.html
Comment 1 Lars Engels freebsd_committer 2017-12-12 17:11:57 UTC
Thanks for the patch, much appreciated!

While the patch for the port is very good, volumeicon-0.5.1 doesn't run properly: When you try to open the preferences window, volumeicon crashes with SIGBUS.

Could you maybe take a look at this?
Comment 2 Dmitri Goutnik freebsd_committer 2017-12-12 18:59:30 UTC
Created attachment 188771 [details]
patch file

Hi Lars,

The updated patch should fix the crash, I also changed the misleading "Alsa" label on the Channels tab to "OSS".

portlint/poudriere testport still OK.
Comment 3 commit-hook freebsd_committer 2017-12-13 10:15:28 UTC
A commit references this bug:

Author: lme
Date: Wed Dec 13 10:15:10 UTC 2017
New revision: 456201
URL: https://svnweb.freebsd.org/changeset/ports/456201

Log:
  audio/volumeicon:

  - Update to 0.5.1
  - Change WWW and download source to Github (MASTER_SITE disappeared)
  - Pet portlint

  PR:		224279
  Submitted by:	Dmitri Goutnik

Changes:
  head/audio/volumeicon/Makefile
  head/audio/volumeicon/distinfo
  head/audio/volumeicon/files/patch-data_gui_preferences.ui
  head/audio/volumeicon/files/patch-src_oss__backend.c
  head/audio/volumeicon/files/patch-src_oss__backend.h
  head/audio/volumeicon/files/patch-src_volumeicon.c
  head/audio/volumeicon/pkg-descr
  head/audio/volumeicon/pkg-plist
Comment 4 Lars Engels freebsd_committer 2017-12-13 10:15:50 UTC
Commited, thanks!