Bug 224370 - Wrong path documented in make package in ports(7)
Summary: Wrong path documented in make package in ports(7)
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-15 19:09 UTC by Jérôme Renard
Modified: 2021-02-19 12:47 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme Renard 2017-12-15 19:09:14 UTC
In man 7 ports (https://www.freebsd.org/cgi/man.cgi?query=ports&sektion=7) the "package" section states the following:


     package              Make a binary package for the port.  The port will
                          be installed if it has not already been.  The
                          package is a .tbz file that you can use to install
                          the port on other machines with pkg-add(8).  If the
                          directory specified by PACKAGES does not exist, the
                          package will be put into the current directory.  See
                          PKGREPOSITORY and PKGFILE.

However when running make package it appears the built package is not a .tbz but a .txz in work/pkg

Maybe it would be great to reword it like this:

     package              Make a binary package for the port.  The port will
                          be installed if it has not already been.  The
                          package is a .txz file that you can use to install
                          the port on other machines with pkg-add(8).  If the
                          directory specified by PACKAGES does not exist, the
                          package will be put into the current directory in 
                          work/pkg. See PKGREPOSITORY and PKGFILE.

:)
Comment 1 Fernando Apesteguía freebsd_committer 2021-02-19 11:23:30 UTC
https://reviews.freebsd.org/D28785
Comment 2 Fernando Apesteguía freebsd_committer 2021-02-19 11:43:38 UTC
This already existent review is more complete.

https://reviews.freebsd.org/D28781
Comment 3 commit-hook freebsd_committer 2021-02-19 12:45:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=248a47a4c2fb229ae815fa61875b3f62a2d6856c

commit 248a47a4c2fb229ae815fa61875b3f62a2d6856c
Author:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
AuthorDate: 2021-02-18 21:50:54 +0000
Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
CommitDate: 2021-02-19 12:42:16 +0000

    ports(7): Update instructions for package target

    Packages default to ending up in a different location compared to the
    documentation, so catch up to the implementation by referring to the
    location where packages can usually be found if no environment variables
    have been set.

    While here, also update the mention of the file extension to match the
    txz format that packages use.

    PR:             253179, 224370
    Reported by:    rwatson, jeromer at fastmail dotnet

 share/man/man7/ports.7 | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Comment 4 Daniel Ebdrup Jensen freebsd_committer 2021-02-19 12:47:47 UTC
Thank you for your attention to detail. :)