Bug 224474 - ports-mgmt/pkg: Copy/paste error in pkg_add.c: "AE_IFFIFO" in the AE_IFBLK case
Summary: ports-mgmt/pkg: Copy/paste error in pkg_add.c: "AE_IFFIFO" in the AE_IFBLK case
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-pkg (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-20 03:20 UTC by david
Modified: 2018-02-15 21:17 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description david 2017-12-20 03:20:22 UTC 
The error message for the AE_IFBLK case in do_extract looks like it was erroneously copied from the AE_IFFIFO case.
https://github.com/freebsd/pkg/blob/144464d6f80e70b0801735b4471f97e6639dfabb/libpkg/pkg_add.c#L682-L683

                case AE_IFIFO:                                                   
                        pkg_emit_error("Archive contains an unsupported filetype (AE_IFFIFO): %s", path);
...
                case AE_IFBLK:                                                   
                        pkg_emit_error("Archive contains an unsupported filetype (AE_IFFIFO): %s", path);
Comment 1 Brad Davis freebsd_committer freebsd_triage 2018-02-15 21:17:29 UTC 
Thanks for the report, I have fixed it in git.

https://github.com/freebsd/pkg/commit/8552aae4d965dbc0979e5ade07678c3e06d3f202

In the future, please open pkg bugs in the github issue tracker there:
https://github.com/freebsd/pkg/issues