Bug 224481 - Add H3 to aw_sid driver for Allwinner SoC
Summary: Add H3 to aw_sid driver for Allwinner SoC
Status: Closed Not A Bug
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: CURRENT
Hardware: arm Any
: --- Affects Many People
Assignee: freebsd-arm (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-20 13:28 UTC by Eugene Sevastyanov
Modified: 2017-12-20 14:05 UTC (History)
2 users (show)

See Also:

Attachments
SID driver patch (5.96 KB, patch)
2017-12-20 13:28 UTC, Eugene Sevastyanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Sevastyanov 2017-12-20 13:28:40 UTC 
Created attachment 188991 [details]
SID driver patch

For the correct operation of the aw_thermal driver, a thermal calibration function is required, presented in the aw_sid driver. However, the driver does not support H3 SoC.
It is known that H3 SoC has a hardware bug when reading SID (root key) - see http://linux-sunxi.org/SID_Register_Guide#SID_PRCTL

I suggest a patch that more correctly implements the aw_sid driver.

DTS to enable the driver device:
...
sid: eeprom@1c14000 {
       compatible = "allwinner,sun8i-h3-sid";
       reg = <0x01c14000 0x400>;
};
...

The driver is tested on H2+ SoC (OrangePi Zero)
Comment 1 Emmanuel Vadot freebsd_committer freebsd_triage 2017-12-20 13:36:06 UTC 
Hello,

Thanks you for you patch, could you open a review on reviews.freebsd.org please ?

It's much easier to review code there.

Thanks.
Comment 2 Emmanuel Vadot freebsd_committer freebsd_triage 2017-12-20 14:05:29 UTC 
Patch moved to phabricator, closing this entry.

https://reviews.freebsd.org/D13556