Bug 224645 - New port: math/cryptominisat4
Summary: New port: math/cryptominisat4
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-28 15:12 UTC by Val Packett
Modified: 2017-12-28 23:51 UTC (History)
1 user (show)

See Also:

Attachments
cryptominisat4.patch (2.14 KB, patch)
2017-12-28 15:12 UTC, Val Packett 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2017-12-28 15:12:23 UTC 
Created attachment 189166 [details]
cryptominisat4.patch

The 4.x version is still required by the CVC4 SMT solver.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-28 18:03:03 UTC 
Thanks for your submission.

The port for cryptominisat already exists: math/cryptominisat
Comment 2 Val Packett 2017-12-28 18:51:42 UTC 
(In reply to Yuri Victorovich from comment #1)
math/cryptominisat is version 5. This is copied from that port, but with the version rolled back to 4.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-28 19:11:47 UTC 
What do CVC4 SMT solver maintainers say, why don't they switch to version 5 of cryptominisat?
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-28 19:14:31 UTC 
Ok, I asked them here: https://github.com/CVC4/CVC4/issues/1454
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-28 22:47:43 UTC 
Greg,

based on their response cryptominisat5 supportis planned, and might be available next year.

If you would like to create a port for CVC4, you can easily bundle cryptominisat4:

> USE_GITHUB=     yes
> GH_TUPLE=       msoos:cryptominisat:4.0.0:cryptominisat/bundled/cryptominisat4

> pre-build:
>  @cd ${WRKSRC}/bundled/cryptominisat4 && ${CMAKE_BIN} -DBUILD_STATIC=ON . && ${MAKE_CMD}

...

then you can use the library/headers from ${WRKSRC}/bundled/cryptominisat4


Cheers,
Yuri
Comment 6 Val Packett 2017-12-28 23:40:10 UTC 
(In reply to Yuri Victorovich from comment #5)
okay. I thought ports were supposed to avoid bundled libraries as much as possible…
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-28 23:51:23 UTC 
(In reply to Greg V from comment #6)

Not as much as possible. They should be avoided when ports exist, or easy to create. In this case it's supposedly a temporary situation, and easy to bundle, so instead of creating a temporary port just bundle it for a while.

Cheers,
Yuri