Bug 224902 - [textproc/py-libxml2] undefined symbol _PyVerify_fd
Summary: [textproc/py-libxml2] undefined symbol _PyVerify_fd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-04 17:01 UTC by Michael Zhilin
Modified: 2018-10-25 19:29 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
SVN patch (1.35 KB, patch)
2018-01-04 17:01 UTC, Michael Zhilin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zhilin 2018-01-04 17:01:21 UTC
Created attachment 189405 [details]
SVN patch

Hi,

_PyVerify_fd has been removed from CPython and it did nothing on Unix boxes. In case of python 3.6 usage of py-libxml2 throws undefined symbol _PyVerify_fd. 

Ticket to gnome is still open: https://bugzilla.gnome.org/show_bug.cgi?id=776815

This patch solves problem. Issue is found by me during upgrade of textproc/itstool from 2.0.2 to 2.0.4.
Comment 1 Roman Bogorodskiy freebsd_committer 2018-10-19 16:37:25 UTC
Any reason that it's still open? Suggested patch looks trivial and very similar to the upstream fix: https://github.com/GNOME/libxml2/commit/d910e99c322a0895955038c700471e9b1fd91fa6
Comment 2 Roman Bogorodskiy freebsd_committer 2018-10-19 16:50:50 UTC
(In reply to Roman Bogorodskiy from comment #1)

Just tested this change and it works fine for me.
Comment 3 commit-hook freebsd_committer 2018-10-25 19:27:23 UTC
A commit references this bug:

Author: kwm
Date: Thu Oct 25 19:26:45 UTC 2018
New revision: 482978
URL: https://svnweb.freebsd.org/changeset/ports/482978

Log:
  Remove usage of _PyVerify_fd().

  This function appears to be removed in python 3.5.0. Instead of adding a
  version check like the submitter proposed. Grab the upstream patch instead
  that just removes the function usage.

  PR:		224902
  Submitted by:	Michael Zhilin <mizhka@gmail.com>
  Obtained from:	libxml2 upstream

Changes:
  head/textproc/libxml2/files/patch-python_types.c
  head/textproc/py-libxml2/Makefile