Bug 225411 - [maintainer update] audio/dsbmixer: Update to 1.3
Summary: [maintainer update] audio/dsbmixer: Update to 1.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-23 19:46 UTC by Marcel Kaiser
Modified: 2018-01-23 22:45 UTC (History)
2 users (show)

See Also:


Attachments
svn diff to upgrade dsbmixer-1.2 to dsbmixer-1.3 (761 bytes, patch)
2018-01-23 19:46 UTC, Marcel Kaiser
no flags Details | Diff
svn diff to upgrade dsbmixer-1.2 to dsbmixer-1.3.1 (767 bytes, patch)
2018-01-23 22:26 UTC, Marcel Kaiser
mk: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Kaiser 2018-01-23 19:46:28 UTC
Created attachment 190010 [details]
svn diff to upgrade dsbmixer-1.2 to dsbmixer-1.3

Changes:

- Support for setting the sysctl variables hw.snd.latency, hw.snd.maxautovchans and hw.snd.vpc_mixer_bypass has been added.

QA:
portlint: OK (looks fine.)
testport: OK (poudriere: 11.1Ramd64, 103Ri386)
Comment 1 Tobias Kortkamp freebsd_committer 2018-01-23 20:41:03 UTC
(In reply to Marcel Kaiser from comment #0)
Hi,

this builds fine, but like dsbmixer 1.2 it crashes for me as soon as I
click on any of the volume sliders or close the window.

I'm using cwm and it doesn't have a system tray so trayIcon may be
uninitialized (MainWin::createTrayIcon() is never called in this
case).  If I run a standalone system tray like x11/stalonetray it
starts working fine.

Sorry for not reporting this sooner.

* thread #1, name = 'dsbmixer', stop reason = signal SIGSEGV
  * frame #0: 0x00000008012c16ac libQt5Core.so.5`QString::operator=(QString const&) + 28
    frame #1: 0x00000008009c2f76 libQt5Widgets.so.5`QSystemTrayIcon::setToolTip(QString const&) + 22
    frame #2: 0x0000000000216ed8 dsbmixer`MainWin::catchMasterVolChanged(this=0x00007fffffffe6c0, vol=80) at mainwin.cpp:348
    frame #3: 0x0000000000224991 dsbmixer`MainWin::qt_static_metacall(_o=0x00007fffffffe6c0, _c=InvokeMetaMethod, _id=9, _a=0x00007fffffffd660) at moc_mainwin.cpp:120
    frame #4: 0x000000080143d97e libQt5Core.so.5`QMetaObject::activate(QObject*, int, int, void**) + 2302
    frame #5: 0x0000000000224db8 dsbmixer`Mixer::masterVolChanged(this=0x000000080774d320, _t1=80) at moc_mixer.cpp:166
    frame #6: 0x000000000021882a dsbmixer`Mixer::setVol(this=0x000000080774d320, chan=0, vol=80) at mixer.cpp:111
    frame #7: 0x0000000000224c4b dsbmixer`Mixer::qt_static_metacall(_o=0x000000080774d320, _c=InvokeMetaMethod, _id=1, _a=0x00007fffffffd7f0) at moc_mixer.cpp:105
    frame #8: 0x000000080143d97e libQt5Core.so.5`QMetaObject::activate(QObject*, int, int, void**) + 2302
    frame #9: 0x0000000000224498 dsbmixer`ChanSlider::VolumeChanged(this=0x000000080777f900, _t1=0, _t2=80) at moc_chanslider.cpp:205
    frame #10: 0x00000000002135bf dsbmixer`ChanSlider::emitVolumeChanged(this=0x000000080777f900, val=80) at chanslider.cpp:159
    frame #11: 0x0000000000224229 dsbmixer`ChanSlider::qt_static_metacall(_o=0x000000080777f900, _c=InvokeMetaMethod, _id=5, _a=0x00007fffffffd9c0) at moc_chanslider.cpp:118
    frame #12: 0x000000080143d97e libQt5Core.so.5`QMetaObject::activate(QObject*, int, int, void**) + 2302
    frame #13: 0x0000000800767101 libQt5Widgets.so.5`QAbstractSlider::setValue(int) + 289
    frame #14: 0x00000008007677e6 libQt5Widgets.so.5`QAbstractSlider::triggerAction(QAbstractSlider::SliderAction) + 198
    frame #15: 0x0000000800809ecc libQt5Widgets.so.5`QSlider::mousePressEvent(QMouseEvent*) + 1452
    frame #16: 0x00000008006afdcb libQt5Widgets.so.5`QWidget::event(QEvent*) + 379
    frame #17: 0x0000000800809902 libQt5Widgets.so.5`QSlider::event(QEvent*) + 338
    frame #18: 0x000000080067a2d0 libQt5Widgets.so.5`QApplicationPrivate::notify_helper(QObject*, QEvent*) + 272
    frame #19: 0x000000080067d009 libQt5Widgets.so.5`QApplication::notify(QObject*, QEvent*) + 7001
    frame #20: 0x000000080140d450 libQt5Core.so.5`QCoreApplication::notifyInternal2(QObject*, QEvent*) + 160
    frame #21: 0x000000080067ac36 libQt5Widgets.so.5`QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget, QWidget, QWidget*, QPointer<QApplicationPrivate::sendMouseEvent>&, bool) + 934
    frame #22: 0x00000008006cedf4 libQt5Widgets.so.5`___lldb_unnamed_symbol426$$libQt5Widgets.so.5 + 1828
    frame #23: 0x00000008006cdd75 libQt5Widgets.so.5`___lldb_unnamed_symbol421$$libQt5Widgets.so.5 + 229
    frame #24: 0x000000080067a2d0 libQt5Widgets.so.5`QApplicationPrivate::notify_helper(QObject*, QEvent*) + 272
    frame #25: 0x000000080067b641 libQt5Widgets.so.5`QApplication::notify(QObject*, QEvent*) + 401
    frame #26: 0x000000080140d450 libQt5Core.so.5`QCoreApplication::notifyInternal2(QObject*, QEvent*) + 160
    frame #27: 0x0000000800bebb10 libQt5Gui.so.5`QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) + 2992
    frame #28: 0x0000000800bd379b libQt5Gui.so.5`QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 219
    frame #29: 0x0000000805e57bc0 libQt5XcbQpa.so.5`___lldb_unnamed_symbol965$$libQt5XcbQpa.so.5 + 16
    frame #30: 0x0000000802301b46 libglib-2.0.so.0`g_main_context_dispatch + 310
    frame #31: 0x0000000802301ee6 libglib-2.0.so.0`___lldb_unnamed_symbol112$$libglib-2.0.so.0 + 534
    frame #32: 0x0000000802301f94 libglib-2.0.so.0`g_main_context_iteration + 100
    frame #33: 0x000000080145eceb libQt5Core.so.5`QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 107
    frame #34: 0x00000008014092de libQt5Core.so.5`QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 430
    frame #35: 0x000000080140dafc libQt5Core.so.5`QCoreApplication::exec(void) + 316
    frame #36: 0x00000000002144f8 dsbmixer`main(argc=0, argv=0x00007fffffffe8a8) at main.cpp:105
    frame #37: 0x000000000021217f dsbmixer`_start(ap=<unavailable>, cleanup=<unavailable>) at crt1.c:74
Comment 2 Steve Wills freebsd_committer 2018-01-23 22:14:52 UTC
(In reply to Tobias Kortkamp from comment #1)
Given that 1.2 is already committed, this shouldn't hold up updating to 1.3, IMHO. You should open a separate ticket for the issue you are having.
Comment 3 Marcel Kaiser 2018-01-23 22:26:20 UTC
Created attachment 190011 [details]
svn diff to upgrade dsbmixer-1.2 to dsbmixer-1.3.1

Changes:

- Support for setting the sysctl variables hw.snd.latency, hw.snd.maxautovchans and hw.snd.vpc_mixer_bypass has been added. (1.3)

-  A bug that lead to a crash when DSBMixer wasn't able to find a system tray has been fixed. (1.3.1)

QA:
portlint: OK (looks fine.)
testport: OK (poudriere: 11.1Ramd64, 103Ri386)
Comment 4 Marcel Kaiser 2018-01-23 22:27:23 UTC
(In reply to Tobias Kortkamp from comment #1)
Hi Tobias,

thanks for pointing that out!
Comment 5 Tobias Kortkamp freebsd_committer 2018-01-23 22:37:55 UTC
(In reply to Marcel Kaiser from comment #4)

It works fine now.  Thank you for the quick fix, Marcel!
Comment 6 commit-hook freebsd_committer 2018-01-23 22:40:00 UTC
A commit references this bug:

Author: tobik
Date: Tue Jan 23 22:39:11 UTC 2018
New revision: 459800
URL: https://svnweb.freebsd.org/changeset/ports/459800

Log:
  audio/dsbmixer: Update to 1.3.1

  - Support for setting the sysctl variables hw.snd.latency,
    hw.snd.maxautovchans and hw.snd.vpc_mixer_bypass has been
    added. (1.3)

  - A bug that lead to a crash when DSBMixer wasn't able to find a
    system tray has been fixed. (1.3.1)

  PR:		225411
  Submitted by:	Marcel Kaiser <mk@nic-nac-project.org> (maintainer)

Changes:
  head/audio/dsbmixer/Makefile
  head/audio/dsbmixer/distinfo
Comment 7 Tobias Kortkamp freebsd_committer 2018-01-23 22:40:32 UTC
Committed, thanks!
Comment 8 Marcel Kaiser 2018-01-23 22:45:10 UTC
(In reply to Tobias Kortkamp from comment #5)
Excellent! Thank you for the fast commit.