Bug 225553 - devel/subversion: [patch]: Fix GPG agent
Summary: devel/subversion: [patch]: Fix GPG agent
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lev A. Serebryakov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-01-30 06:40 UTC by Peter Laursen
Modified: 2018-01-30 12:33 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (lev)

Attachments
patch-Makefile.common.xz: Adds description of GPG_AGENT option and adds dependencies. (364 bytes, application/x-xz)
2018-01-30 06:40 UTC, Peter Laursen 		no flags Details
patch-Makefile.xz: Upgrade PORTREVISION, add GPG_AGENT option (548 bytes, patch)
2018-01-30 06:43 UTC, Peter Laursen 		no flags Details | Diff
Makes GPG-Agent work (1.81 KB, patch)
2018-01-30 06:44 UTC, Peter Laursen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Laursen 2018-01-30 06:40:44 UTC 
Created attachment 190186 [details]
patch-Makefile.common.xz: Adds description of GPG_AGENT option and adds dependencies.

Hi,
When subversion is installed, it is currently compiled without GPG agent support.
However, if you build devel/subversion from ports after having installed security/gnupg, Subversion automatically picks up security/gnupg and tries to enable support for GPG agent.
This support, however, does not work for our version of GPG-agent - even though GPG-agent is started, Subversion cannot find it.

Attached to this PR are three patches:
1) patch-Makefile.xz: Upgrades PORTREVISION and adds GPG_AGENT as an option (off by default)
2) patch-Makefile.common.xz: Adds the necessary dependencies and a description
3) patch-subversion_libsvn__subr_gpg__agent.c.xz: A patch that makes gpg-agent work. The patch is pulled from the upcoming Subversion 1.10.

I have verified that the build works on i386/amd64 using Poudriere.

If there are any questions (or if I can do anything further to help), please let me know.

All the best,

Peter.
Comment 1 Peter Laursen 2018-01-30 06:43:36 UTC 
Created attachment 190187 [details]
patch-Makefile.xz: Upgrade PORTREVISION, add GPG_AGENT option
Comment 2 Peter Laursen 2018-01-30 06:44:29 UTC 
Created attachment 190188 [details]
Makes GPG-Agent work
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-01-30 12:32:03 UTC 
A commit references this bug:

Author: lev
Date: Tue Jan 30 12:31:06 UTC 2018
New revision: 460383
URL: https://svnweb.freebsd.org/changeset/ports/460383

Log:
   Add optional support for gpg-agent

  PR:		225553
  Submitted by:	Peter Laursen <plaursen@kobalt.dk>
  Reported by:	Peter Laursen <plaursen@kobalt.dk>

Changes:
  head/devel/subversion/Makefile
  head/devel/subversion/Makefile.common
  head/devel/subversion/files/patch-subversion_libsvn_subr_gpg_agent.c
Comment 4 Lev A. Serebryakov freebsd_committer freebsd_triage 2018-01-30 12:33:46 UTC 
Committed, thanx!