Bug 225647 - www/mod_wsgi4: Support FLAVORS
Summary: www/mod_wsgi4: Support FLAVORS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-03 14:31 UTC by Christian Ullrich
Modified: 2018-02-06 18:45 UTC (History)
2 users (show)

See Also:
douglas: maintainer-feedback+

Attachments
Patch (657 bytes, patch)
2018-02-03 14:31 UTC, Christian Ullrich 		douglas: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ullrich 2018-02-03 14:31:48 UTC 
Created attachment 190297 [details]
Patch

www/mod_wsgi4 does not support FLAVORS and hence can currently only be built with the default Python version (i.e. Python 2.7 in approximately all cases).

Because mod_wsgi4 does not support being loaded in both Python 2 and Python 3 versions at the same time, there is no complex machinery required to ensure that installed files do not conflict (leaving aside the situation where someone is running two Apaches on the same system).

Proposed patch attached. This patch results in a PKGNAMEPREFIX of the form "ap24-py36-".
Comment 1 Douglas Thrift 2018-02-03 23:14:10 UTC 
Comment on attachment 190297 [details]
Patch

This looks fine to me. Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-02-06 18:44:37 UTC 
A commit references this bug:

Author: joneum
Date: Tue Feb  6 18:44:20 UTC 2018
New revision: 461083
URL: https://svnweb.freebsd.org/changeset/ports/461083

Log:
  www/mod_wsgi4: Support FLAVORS

  PR:		225647
  Submitted by:	Christian Ullrich <chris@chrullrich.net>
  Approved by:	Douglas Thrift <douglas@douglasthrift.net> (maintainer)
  Approved by:	mat, tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D14191

Changes:
  head/www/mod_wsgi4/Makefile
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2018-02-06 18:45:57 UTC 
Landed. Thanks :-)