Bug 225686 - net/drawterm: switch to 9front fork, add DragonflyBSD compatibility, remove patches
Summary: net/drawterm: switch to 9front fork, add DragonflyBSD compatibility, remove p...
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-02-05 15:27 UTC by Piotr Kubaj
Modified: 2019-01-18 21:40 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (winston)


Attachments
patch (2.74 KB, patch)
2018-02-05 15:27 UTC, Piotr Kubaj
no flags Details | Diff
patch (3.61 KB, patch)
2018-03-21 15:40 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-02-05 15:27:31 UTC
Created attachment 190342 [details]
patch

This patch switches drawterm port to use 9front's fork. It also adds DragonflyBSD compatibility.

Tested on Poudriere on FreeBSD.
Comment 1 winston 2018-03-04 21:04:10 UTC
Hello, I have contacted Piotr and they're interested in taking over this port. Thanks, Piotr!
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-03-21 15:40:50 UTC
Created attachment 191706 [details]
patch

* update to a newer version which includes a manpage
* respect CFLAGS
* add -fPIC to CFLAGS
* change maintainer
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-02 09:13:19 UTC
This needs to be locked to a specific commit.  Using 'tip' isn't appropriate
as it changes over time for every new upstream commit.

It would also be nice to give the distfile a unique filename (probably using
the /?dummy= trick other ports use).

+.if ${OPSYS} == "FreeBSD"
+MAKE_ARGS=	CONF=freebsd
+.else
+MAKE_ARGS=	CONF=dragonfly
+.endif

Since this set after including bsd.port.pre.mk it should be MAKE_ARGS+= or it
overwrites MAKE_ARGS as set by the framework, but all of this can be done
declaratively without the bsd.port.{pre,post}.mk dance with just

MAKE_ARGS=	CONF=${OPSYS:tl}