Created attachment 190346 [details] patch Translate more pre UAL to UAL opcode. fix armv7 detection.
anyone? it blocks 401 on armv6 Thanks in advance.
Hi Mikael, Thanks for submitting this. While the changeset is small, the biggest issue here will probably be committers not having access to (arm) hardware to test/QA with, using poudriere specifically. It would be great if you (or someone else: linimon?) could confirm QA/packaging using poudriere, ideally for all major versions (10/11/12) and no regressions on i386/amd64. Logs are not required, just confirmation of what version/arch combinations have been tested.
It builds fine on armv7 12-current. My patch only touches arm files, it should be a noop on !arm architecture.
(In reply to mikael.urankar from comment #3) I noticed that, thanks for the quick feedback
(In reply to mikael.urankar from comment #3) This is true, but with so many ports being dependent on openblas, I hesitate to commit any patches without regression-testing on e.g. amd64. I am willing to do this but will not have a time-slice until next week. Oddly I have the following: mnx% pwd /var/www/lonesome.com/htdocs/FreeBSD/FreeBSD:12:armv7/quarterly mnx% ls -al All/*openblas* -rw-r--r-- 1 linimon wheel 7595956 Jan 31 21:27 All/openblas-0.2.20_1,1.txz so at some point I built it on armv7. (I am having to shuffle machines around so I do not know if I was running with your patches.) This would have been via # $FreeBSD: branches/2018Q1/math/openblas/Makefile 449591 2017-09-10 20:55:38Z gerald $
(In reply to Mark Linimon from comment #5) It builds fine on 10.4 amd64/i386 and 11.1 amd64/i386 with 2018Q1 ports tree, build logs available here: http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-0.2.20_1_104amd64-2018Q1.log http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-0.2.20_1_104i386-2018Q1.log http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-0.2.20_1_111amd64-2018Q1.log http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-0.2.20_1_111i386-2018Q1.log The problem arose with the clang6 update.
(In reply to mikael.urankar from comment #6) Any chance of confirming QA with ports 'latest' for no regressions on i386/amd64? While unlikely, that branch's userbase is much larger and there is a sufficient delta between branches to be cautious
(In reply to Kubilay Kocak from comment #7) I can try it again today. Once again, I find myself having to create a new hard drive. Please be patient.
(In reply to Kubilay Kocak from comment #7) build logs with ports tree at r465782 http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-104amd64-default.log http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-104i386-default.log http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-111amd64-default.log http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-111i386-default.log
@phd_kimberlite Could you please approve the attachment (the patch), if you approve. Attachment -> Details -> maintainer-approval [+]
A commit references this bug: Author: linimon Date: Thu Mar 29 04:04:22 UTC 2018 New revision: 465863 URL: https://svnweb.freebsd.org/changeset/ports/465863 Log: Patch to fix build on armvX. Tested for no-harm on amd64. PR: 225693 Submitted by: mikael.urankar Approved by: maintainer timeout (> 2 weeks) Changes: head/math/openblas/files/patch-common__arm.h head/math/openblas/files/patch-cpuid__arm.c