Bug 225835 - [PATCH] games/torcs : Fix build in 12-current
Summary: [PATCH] games/torcs : Fix build in 12-current
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-02-11 21:42 UTC by Thibault Payet
Modified: 2018-02-24 00:30 UTC (History)
1 user (show)

See Also:

Attachments
patch for 12-current (3.06 KB, patch)
2018-02-11 21:42 UTC, Thibault Payet 		monwarez: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Payet 2018-02-11 21:42:17 UTC 
Created attachment 190522 [details]
patch for 12-current

It pass QA

This should fix compiler issue about correct casting.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-02-24 00:29:08 UTC 
A commit references this bug:

Author: madpilot
Date: Sat Feb 24 00:28:10 UTC 2018
New revision: 462754
URL: https://svnweb.freebsd.org/changeset/ports/462754

Log:
  Fix build with clang 6.

  The fix also causes the port to fail on 10.x, so add USES-compiler
  and USE_CXXSTD=c++11 to address that problem too.

  PR:		225835
  Submitted by:	Thibault Payet <monwarez@mailoo.org> (maintainer)

Changes:
  head/games/torcs/Makefile
  head/games/torcs/files/patch-Make-default.mk
  head/games/torcs/files/patch-src_drivers_olethros_driver.cpp
  head/games/torcs/files/patch-src_libs_musicplayer_OpenALMusicPlayer.cpp
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2018-02-24 00:30:12 UTC 
Fix committed. Thanks!

As stated in the commit message some further work was needed to keep the port compile on 10.4.

BTW for build fixes PORTREVISION bumps are not needed as long as the already built packages work fine where they succeed to build.